Page MenuHomeFreeBSD

rtwn: create a new HAL routine for enabling STA mode beacon processing
ClosedPublic

Authored by adrian on Dec 13 2024, 4:12 AM.
Referenced Files
Unknown Object (File)
Fri, Jan 24, 2:56 AM
Unknown Object (File)
Mon, Jan 13, 5:51 AM
Unknown Object (File)
Dec 26 2024, 2:11 AM
Unknown Object (File)
Dec 25 2024, 12:13 PM
Unknown Object (File)
Dec 25 2024, 11:25 AM
Unknown Object (File)
Dec 25 2024, 11:20 AM
Unknown Object (File)
Dec 25 2024, 7:31 AM
Unknown Object (File)
Dec 22 2024, 8:19 PM
Subscribers

Details

Summary

For some NICs (notably the rtl8192cu that I'm working on) the
firmware rate adaptation requires beacon processing to be enabled.

Instead of making assumptions in the if_rtwn beacon routines (and
honestly all of that should be in the HAL too), create a HAL method
for enabling/disabling beacon processing specifically in STA mode.

Since this isn't necessarily required for all NICs (notably the RTL8188E
NICs, where some will do firmware rate control and some will require
driver rate control), only enable it for the RTL8192CU and RT8192EU.

The RTL8188E and RTL8812/RTL8821 just have no-op routines for now.

Locally tested:

  • RTL8192CU, STA mode

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61134
Build 58018: arc lint + arc unit

Event Timeline

bz requested changes to this revision.Dec 18 2024, 12:55 PM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/rtwn/rtl8192c/r92c_beacon.c
94

I'll mark it here for the entire file: "enable" is a bool; please use that in new code and no longer an int.

This revision now requires changes to proceed.Dec 18 2024, 12:55 PM

use bool; requested by bz@

Missed one but good apart from that; I'll trust you to fix this before commit. Thank you!

sys/dev/rtwn/rtl8192c/r92c_beacon.c
73

bool

bz requested changes to this revision.Dec 19 2024, 10:46 AM
This revision now requires changes to proceed.Dec 19 2024, 10:46 AM
sys/dev/rtwn/rtl8192c/r92c_beacon.c
73

This is an existing routine, not a new one. I'll do a subsequent commit after this stack lands to clean the non-STA beacon API up!

emaste added inline comments.
sys/dev/rtwn/rtl8192c/r92c_beacon.c
73

I think including a change to bool on this would be fine rolled into this commit, but it doesn't really matter, fine as a subsequent cleanup too.

bz added inline comments.
sys/dev/rtwn/rtl8192c/r92c_beacon.c
73

Sorry. My fault.

This revision is now accepted and ready to land.Dec 19 2024, 5:14 PM