Page MenuHomeFreeBSD
Differential D48098

rtwn: add rtwn_ctl_vhtrate(), some cleanups
ClosedPublic
Actions

Authored by adrian on Sun, Dec 15, 10:59 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Jan 1, 1:00 AM
Unknown Object (File)
Thu, Dec 26, 3:32 AM
Unknown Object (File)
Thu, Dec 26, 12:33 AM
Unknown Object (File)
Wed, Dec 25, 2:25 PM
Unknown Object (File)
Wed, Dec 25, 7:02 AM
Unknown Object (File)
Mon, Dec 23, 5:46 PM
Unknown Object (File)
Mon, Dec 23, 1:16 PM
Unknown Object (File)
Thu, Dec 19, 7:17 PM
Subscribers
bz
fuz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG06b7335701fa: rtwn: add rtwn_ctl_vhtrate(), some cleanups
Summary
  • Add a placeholder rtwn_ctl_vhtrate() which returns the dot11rate control rate to use for the given VHT rate index. Since net80211 currently doesn't have any VHT PHY tables, there's no mapping for us to leverage so just return OFDM 12M for now.
  • Use the new macro to convert rate index to MCS rate
  • Add a printf() in rate2ridx if it's passed a HT/VHT rate.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Sun, Dec 15, 10:59 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Dec 15, 10:59 PM
adrian requested review of this revision.Sun, Dec 15, 10:59 PM
Harbormaster completed remote builds in B61186: Diff 147998.Sun, Dec 15, 10:59 PM
adrian added a parent revision: D48097: rtwn: enable VHT if it's configured in the device.Sun, Dec 15, 11:00 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D48099: rtwn: add VHT information to TX rate completion.Sun, Dec 15, 11:29 PM
fuz added a subscriber: fuz.Thu, Dec 26, 10:43 PM

That stub looks sane.

bz added a subscriber: bz.Fri, Dec 27, 7:12 AM
bz added inline comments.
sys/dev/rtwn/if_rtwn_ridx.h
96

return takes ()

bz added a comment.Tue, Dec 31, 6:49 AM

otherwise I am fine with it if you are.

sys/dev/rtwn/if_rtwn_ridx.h
116–129

and while here you could add them here too and the file might be neat and tidy ;-)

142

Here too.

adrian updated this revision to Diff 148593.Tue, Dec 31, 8:08 AM

address feedback from bz

Harbormaster completed remote builds in B61425: Diff 148593.Tue, Dec 31, 8:08 AM
bz accepted this revision as: bz.Tue, Dec 31, 9:05 AM
This revision is now accepted and ready to land.Tue, Dec 31, 9:05 AM
Closed by commit rG06b7335701fa: rtwn: add rtwn_ctl_vhtrate(), some cleanups (authored by adrian). · Explain WhyTue, Dec 31, 7:14 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG06b7335701fa: rtwn: add rtwn_ctl_vhtrate(), some cleanups.
adrian added a child revision: D48100: rtwn: add forcerate flag to TX descriptor setup.Thu, Jan 9, 5:07 PM
adrian removed a child revision: D48099: rtwn: add VHT information to TX rate completion.Thu, Jan 9, 5:10 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
45 lines

Diff 148618

View Options

sys/dev/rtwn/if_rtwn_ridx.h

Loading...