Differential D48118

rtwn: set the maximum AMPDU size correctly for RTL8812AU/RTL8821AU
ClosedPublic
Actions

Authored by adrian on Tue, Dec 17, 5:37 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, Jan 8, 3:25 AM

	Unknown Object (File)
	Thu, Dec 26, 8:18 AM

	Unknown Object (File)
	Thu, Dec 26, 5:24 AM

	Unknown Object (File)
	Wed, Dec 25, 8:39 AM

	Unknown Object (File)
	Mon, Dec 23, 8:48 AM

	Unknown Object (File)
	Sat, Dec 21, 5:00 PM

	Unknown Object (File)
	Thu, Dec 19, 6:06 PM

	Unknown Object (File)
	Wed, Dec 18, 8:07 PM

View All 10 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGdd58d03a2a46: rtwn: set the maximum A-MPDU size correctly for RTL8812AU/RTL8821AU

Summary

The vendor driver sets it to 64k or 128k depending upon chipset,
along with bit 31 being set.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Tue, Dec 17, 5:37 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Dec 17, 5:37 AM

adrian requested review of this revision.Tue, Dec 17, 5:37 AM

Harbormaster completed remote builds in B61213: Diff 148133.Tue, Dec 17, 5:37 AM

adrian added a parent revision: D48113: rtwn: don't set the RTS/CTS primary channel field for RTL8812AU/RTL8821AU.Tue, Dec 17, 5:37 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D48140: rtwn: explicitly configure RTS based on basic rates.Thu, Dec 19, 2:22 AM

Also reasonable.

Adjust the comments and good to go I would say.

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c
144	Funny, what is that value doing? 11n PLCP is 64k max. Oh this one does 11ac as well. Rightyho.
sys/dev/rtwn/rtl8812a/usb/r12au_init.c
147	A-MPDU also in the 1st line of the commit message
151	I think the comment should extend to what's in the commit message about the high bit always being set by the vendor driver.

This revision is now accepted and ready to land.Tue, Jan 7, 7:14 PM

feedback from bz

This revision now requires review to proceed.Wed, Jan 8, 2:30 AM

Harbormaster completed remote builds in B61571: Diff 148923.Wed, Jan 8, 2:30 AM

adrian marked 2 inline comments as done.Wed, Jan 8, 2:30 AM

adrian added inline comments.

sys/dev/rtwn/rtl8812a/usb/r12au_init.c
147	i'll fix that in the commit ;otherwise it'll break git arc update

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 8, 2:59 AM

Closed by commit rGdd58d03a2a46: rtwn: set the maximum A-MPDU size correctly for RTL8812AU/RTL8821AU (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian marked an inline comment as done.

adrian added a commit: rGdd58d03a2a46: rtwn: set the maximum A-MPDU size correctly for RTL8812AU/RTL8821AU.

adrian added a child revision: D48239: ath_hal_ar9300: quick refactor of tx/rx chain handling.Thu, Jan 9, 5:07 PM

adrian removed a child revision: D48140: rtwn: explicitly configure RTS based on basic rates.Thu, Jan 9, 5:11 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

rtl8812a/

1 line

usb/

1 line

12 lines

rtl8821a/

usb/

1 line

Diff 148925

sys/dev/rtwn/rtl8812a/r12a_var.h

Loading...

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c

Loading...

sys/dev/rtwn/rtl8812a/usb/r12au_init.c

Loading...

sys/dev/rtwn/rtl8821a/usb/r21au_attach.c

Loading...