Differential D47993

rtwn: update rtwn_get_rates() to separate out the CCK/OFDM and HT rates
ClosedPublic
Actions

Authored by adrian on Dec 8 2024, 8:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 26, 8:49 AM

	Unknown Object (File)
	Thu, Dec 26, 3:08 AM

	Unknown Object (File)
	Wed, Dec 25, 11:08 AM

	Unknown Object (File)
	Wed, Dec 25, 8:10 AM

	Unknown Object (File)
	Wed, Dec 25, 4:04 AM

	Unknown Object (File)
	Wed, Dec 25, 12:26 AM

	Unknown Object (File)
	Sun, Dec 15, 9:06 AM

Subscribers

Details

Reviewers

imp
bz

Commits

rG745a85824748: rtwn: update rtwn_get_rates() to separate out the CCK/OFDM and HT rates

Summary

The 32 bit bitmap is enough for CCK/OFDM rates and MCS0..15, but
won't work for > MCS15, nor VHT rates.

So, break out the legacy rates and HT rates.

break the rates and htrates out
document which calls are looking up basic rates and which care about the rates themselves
ensure the rate bitmap passed into the rate control firmware call (which isn't enabled yet!) is capped at 28 bits so they don't set the mode field.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 8 2024, 8:25 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2024, 8:25 PM

adrian requested review of this revision.Dec 8 2024, 8:25 PM

Harbormaster completed remote builds in B61037: Diff 147705.Dec 8 2024, 8:25 PM

adrian added a parent revision: D47990: rtwn: bump up the RX USB buffers.Dec 8 2024, 8:26 PM

adrian added a child revision: D48004: rtwn: add SGI flag for the rate control message.Dec 9 2024, 7:25 PM

fix a typo!

Harbormaster completed remote builds in B61062: Diff 147766.Dec 10 2024, 5:58 AM

update after rebase

Harbormaster completed remote builds in B61063: Diff 147767.Dec 10 2024, 6:01 AM

imp accepted this revision.Thu, Dec 12, 6:12 PM

This revision is now accepted and ready to land.Thu, Dec 12, 6:12 PM

bz accepted this revision.Wed, Dec 18, 10:58 AM

Closed by commit rG745a85824748: rtwn: update rtwn_get_rates() to separate out the CCK/OFDM and HT rates (authored by adrian). · Explain WhyWed, Dec 18, 11:50 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG745a85824748: rtwn: update rtwn_get_rates() to separate out the CCK/OFDM and HT rates.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

3 lines

3 lines

30 lines

rtl8192c/

15 lines

rtl8812a/

3 lines

Diff 148226

sys/dev/rtwn/if_rtwn.c

Loading...

sys/dev/rtwn/if_rtwn_rx.h

Loading...

sys/dev/rtwn/if_rtwn_rx.c

Loading...

sys/dev/rtwn/rtl8192c/r92c_fw.c

Loading...

sys/dev/rtwn/rtl8812a/r12a_chan.c

Loading...