Page MenuHomeFreeBSD
Differential D48026

rtwn: disable a workaround introduced earlier for RTL8192CU TX performance
ClosedPublic
Actions

Authored by adrian on Wed, Dec 11, 5:19 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:43 PM
Unknown Object (File)
Thu, Dec 19, 8:42 PM
Unknown Object (File)
Thu, Dec 19, 4:14 PM
Unknown Object (File)
Sun, Dec 15, 4:04 AM
Unknown Object (File)
Wed, Dec 11, 12:47 PM
Subscribers
bz
emaste
imp

Details

Reviewers
imp
Group Reviewers
wireless
Commits
rGeb6314510c88: rtwn: disable a workaround introduced earlier for RTL8192CU TX performance
Summary

I'm unable to reproduce the original problem with my RTL8192CU USB
devices with the current codebase and I can't find any reference
to what this power register is doing - I see it defined in drivers,
but it's not described or used anywhere.

This reverts 7f740971658d71c1ee95ee68032b4696c1684845 -
rtwn_usb(4): fix Tx instability with RTL8192CU chipsets

In any case being able to do higher rate RTS/CTS is beneficial.

Local testing:

  • rtl8192cu, STA mode, TX/RX testing

PR: 233949

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Wed, Dec 11, 5:19 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Dec 11, 5:19 AM
adrian requested review of this revision.Wed, Dec 11, 5:19 AM
Harbormaster completed remote builds in B61079: Diff 147807.Wed, Dec 11, 5:19 AM
adrian added a parent revision: D48019: rtwn: add a default OFDM and MCS0 rate for self-generated frames.Wed, Dec 11, 5:23 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
imp accepted this revision.Thu, Dec 12, 6:01 PM

With the caveat that you'd monitor BZ and the lists for regressions this might cause that you don't anticipate...

This revision is now accepted and ready to land.Thu, Dec 12, 6:01 PM
adrian added a child revision: D48066: rtwn: create a new HAL routine for enabling STA mode beacon processing.Fri, Dec 13, 4:13 AM
emaste added a subscriber: emaste.Fri, Dec 13, 2:55 PM

With the caveat that you'd monitor BZ and the lists for regressions this might cause that you don't anticipate...

Yeah, and maybe a note in UPDATING and/or a heads-up on -current that a workaround was removed and request to look out for regressions.

bz added a subscriber: bz.Wed, Dec 18, 12:47 PM

Please use a Fixes: line in the commit message or similar whatever the template suggests for reverts.

Also wireless list in addition to what @emaste suggested.

Closed by commit rGeb6314510c88: rtwn: disable a workaround introduced earlier for RTL8192CU TX performance (authored by adrian). · Explain WhyThu, Dec 19, 4:09 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rGeb6314510c88: rtwn: disable a workaround introduced earlier for RTL8192CU TX performance.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8192c/
6 lines
usb/
2 lines

Diff 148245

View Options

sys/dev/rtwn/rtl8192c/r92c_tx.c

Loading...
View Options

sys/dev/rtwn/rtl8192c/usb/r92cu_init.c

Loading...