User Details
- User Since
- Jun 2 2014, 4:20 PM (519 w, 6 d)
Today
Yesterday
Thu, May 16
What does nvmecontrol identify ndaX say here? What's the optimal I/O boundary? And maybe we should just have a knob to disable trying to use it.
Wed, May 15
Respectfully, this code is non-standards-conforming, since the standard doesn't allow multiple variable sized elements in a structure.
It's all one sentence one line with a couple minor tweaks that are easy to review.
Yes
Then a quick line in yhe commit messafe saying its a fix
I don't know.. has soft updates cooked enough ? :)
Tue, May 14
I'd be more inclined to land the other review, but until it does, this isn't bad.
S/lube/line/. Stupid autocowrecked
Other arch? At the very least a lube in the commit about why not relevant there
Yea. I didn't like it either.
I could move the timeouts into qpair. Then there'd be no more computing the values... I'd have to plumb the sysctl too... it would be cleaner. I could also put the soft timeout in there too. Then it wouldn't be so arbitrary.
Mon, May 13
A 32bit freebsd cat reading /compat/linux/mumble
Generally i like it. It does seem to mix memory leak / style fixed in with the new functionality.
Sun, May 12
Sat, May 11
Fri, May 10
So I was aware of this and preferred the pull request. It documented the current policy that's been in place for a while.
I appreciate the views expressed here, but I think it is better to try to resolve this by getting a broader consensus than we can get in a phab review.
I kinda think the project went a little far in subscribing to bde's views on this, but I don't think we'd be well served making a big change to this policy (which has a lot of lurking emotion behind it) via only a phab request.
I do think there's some sympathy for documenting / standardizing at least some of these values, but also a recognition that some are overlapping and confusing and were just Eric's first guess at what to do in sendmail for different errors.
Thu, May 9
Since these aren't exported or used anywhere, I think they are safe to remove.
Wed, May 8
What do you do if neither INET nor INET6 are defined? In a lot of cases, it looks like you fail. Likewise for when you don't have the right address family compiled in.
Tue, May 7
makes sense @emaste. Thanks!
The build is good, modulo one quibble.
The rest looks OK, but is really too large for me to review.