Page MenuHomeFreeBSD
Differential D48088

rtwn: enable periodic TX reporting support on RTL8188EU NICs.
ClosedPublic
Actions

Authored by adrian on Sun, Dec 15, 4:54 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Dec 31, 7:14 PM
Unknown Object (File)
Tue, Dec 31, 7:14 PM
Unknown Object (File)
Thu, Dec 26, 8:46 AM
Unknown Object (File)
Wed, Dec 25, 10:58 AM
Unknown Object (File)
Wed, Dec 25, 8:50 AM
Unknown Object (File)
Wed, Dec 25, 4:00 AM
Unknown Object (File)
Sun, Dec 22, 10:11 PM
Unknown Object (File)
Sun, Dec 22, 9:56 AM
View All 10 Files
Subscribers
bz
fuz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGaf2e102c4065: rtwn: enable periodic TX reporting support on RTL8188EU NICs.
Summary

The RTL8188E firmware doesn't have the "full" offload firmware
rate control. Instead, the vendor driver has a bunch of logic
in the driver for rate probing and selection.

Part of this is the periodic TX report - which uploads a summary
of multi-rate retries and drops per MAC. Using it drastically
cuts down on the TX notifications - it's fired from a timer
(defaulting to ~ 1.6 seconds) and is a single receive frame in
the normal bulk RX path.

I've not ported / reimplemented the whole vendor driver rate adaption
code - instead, I'm just using the normal net80211 rate control APIs.
It seems to behave OK - I get 25-30mbit down and 20mbit up using TCP/
speedtest.

Locally tested:

  • RTL8188EU, STA mode

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Sun, Dec 15, 4:54 AM
Herald added a subscriber: imp. · View Herald TranscriptSun, Dec 15, 4:54 AM
adrian requested review of this revision.Sun, Dec 15, 4:54 AM
Harbormaster completed remote builds in B61167: Diff 147968.Sun, Dec 15, 4:54 AM
adrian added a parent revision: D48084: rtwn: add support for register IO debugging.Sun, Dec 15, 4:55 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D48092: rtwn: remove SEQ_SEL, replace with a QOS bit.Sun, Dec 15, 6:21 PM
fuz added a subscriber: fuz.Thu, Dec 26, 11:06 PM

I'm confused about your loop. It should be refactored.

sys/dev/rtwn/rtl8188e/r88e.h
89–90

For consistency.

sys/dev/rtwn/rtl8188e/r88e_rx.c
243

As per style(9)

262–264
280–281

Though I must say the whole valid variable is suspicious and should be eliminated; just move the check here, you don't need it then.

313

valid is always true at this point.

324–325

This is a for loop, make it one.

adrian updated this revision to Diff 148411.Fri, Dec 27, 1:28 AM

updates from fuz@, thx!

Harbormaster completed remote builds in B61340: Diff 148411.Fri, Dec 27, 1:28 AM
adrian marked 3 inline comments as done.Fri, Dec 27, 1:38 AM
adrian updated this revision to Diff 148412.Fri, Dec 27, 1:39 AM

oops, also fix this

Harbormaster completed remote builds in B61341: Diff 148412.Fri, Dec 27, 1:40 AM
adrian marked an inline comment as done.Fri, Dec 27, 1:40 AM

updated, please re-review! thanks!

adrian updated this revision to Diff 148413.Fri, Dec 27, 1:41 AM

update again!

Harbormaster completed remote builds in B61342: Diff 148413.Fri, Dec 27, 1:41 AM
adrian marked an inline comment as done.Fri, Dec 27, 1:41 AM
fuz added a comment.Fri, Dec 27, 11:03 AM

Looks better, but could still be improved.

sys/dev/rtwn/rtl8188e/r88e_rx.c
272–276
284–285

Eliminate the valid variable.

adrian updated this revision to Diff 148447.Fri, Dec 27, 9:18 PM

more suggestions from fuz@

Harbormaster completed remote builds in B61360: Diff 148447.Fri, Dec 27, 9:18 PM
adrian marked 3 inline comments as done.Sat, Dec 28, 2:05 AM
fuz added a comment.Sat, Dec 28, 1:07 PM

Looks good now.

bz accepted this revision as: bz.Tue, Dec 31, 6:45 AM
bz added a subscriber: bz.

Looks OK.

IMPORTANT: given you indicate that this is a partial adaption from upstream rewritten to net80211 it would be good to mention the repo URL and revision/hash this information is based on; I am not expecting adjustments to these registers or structs anymore if firmware changes but realtek sometimes seems to(?). And that's one of the problems we have with all the ported from upstream possibly through OBSD even that we have no way to track this information back to the original source at time. So would really appreciate if it's added if relevant enough.
This revision is now accepted and ready to land.Tue, Dec 31, 6:45 AM
adrian added a comment.Tue, Dec 31, 7:55 AM
In D48088#1100632, @bz wrote:

Looks OK.

IMPORTANT: given you indicate that this is a partial adaption from upstream rewritten to net80211 it would be good to mention the repo URL and revision/hash this information is based on; I am not expecting adjustments to these registers or structs anymore if firmware changes but realtek sometimes seems to(?). And that's one of the problems we have with all the ported from upstream possibly through OBSD even that we have no way to track this information back to the original source at time. So would really appreciate if it's added if relevant enough.

Lemme go find the reference in the rtl8188eu original driver, stay tuned.

adrian added a comment.Tue, Dec 31, 8:11 AM

For reference, it's ODM_RA_TxRPT2Handle_8188E() in the rtl8188eu repository.

https://github.com/lwfinger/rtl8188eu/blob/master/hal/Hal8188ERateAdaptive.c#L675

Closed by commit rGaf2e102c4065: rtwn: enable periodic TX reporting support on RTL8188EU NICs. (authored by adrian). · Explain WhyTue, Dec 31, 7:13 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rGaf2e102c4065: rtwn: enable periodic TX reporting support on RTL8188EU NICs..

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
1 line
rtl8188e/
1 line
86 lines
14 lines
usb/
4 lines
15 lines
rtl8192c/
23 lines

Diff 148616

View Options

sys/dev/rtwn/if_rtwnvar.h

Loading...
View Options

sys/dev/rtwn/rtl8188e/r88e.h

Loading...
View Options

sys/dev/rtwn/rtl8188e/r88e_rx.c

Loading...
View Options

sys/dev/rtwn/rtl8188e/r88e_rx_desc.h

Loading...
View Options

sys/dev/rtwn/rtl8188e/usb/r88eu_attach.c

Loading...
View Options

sys/dev/rtwn/rtl8188e/usb/r88eu_init.c

Loading...
View Options

sys/dev/rtwn/rtl8192c/r92c_tx.c

Loading...