Page MenuHomeFreeBSD

rtwn: remove SEQ_SEL, replace with a QOS bit
ClosedPublic

Authored by adrian on Dec 15 2024, 6:20 PM.
Referenced Files
Unknown Object (File)
Sun, Mar 16, 2:42 AM
Unknown Object (File)
Fri, Feb 28, 9:34 AM
Unknown Object (File)
Fri, Feb 21, 10:01 PM
Unknown Object (File)
Feb 16 2025, 10:34 PM
Unknown Object (File)
Feb 14 2025, 5:11 PM
Unknown Object (File)
Feb 11 2025, 11:43 PM
Unknown Object (File)
Feb 7 2025, 10:17 AM
Unknown Object (File)
Feb 4 2025, 3:07 AM
Subscribers

Details

Summary

I've reviewed all of the linux vendor and upstream drivers.
This SEQ_SEL field isn't a mask and doesn't ever look like it
it was; instead this bit is set to tag QoS data frames.

In fact, it effectively was set to 0 for STA frames and potentially 1
for broadcast/multicast frames as the STA macid of 0 and broadcast/
multicast macid of 1 maps to that. In AP modes it would be tagged
based on bit 0.

So, bring it in line with the vendor and linux drivers.

Locally tested:

  • RTL8192CU, STA, hostap
  • RTL8188EU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable