Differential D47979

rtwn: add APIs for setting transmit power
ClosedPublic
Actions

Authored by adrian on Dec 7 2024, 4:34 PM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Dec 26, 4:26 AM

	Unknown Object (File)
	Wed, Dec 25, 9:19 PM

	Unknown Object (File)
	Wed, Dec 25, 11:08 AM

	Unknown Object (File)
	Wed, Dec 25, 10:31 AM

	Unknown Object (File)
	Wed, Dec 25, 9:31 AM

	Unknown Object (File)
	Wed, Dec 25, 4:34 AM

	Unknown Object (File)
	Wed, Dec 25, 3:16 AM

	Unknown Object (File)
	Thu, Dec 19, 2:57 PM

View All 9 Files

Subscribers

Details

Reviewers

imp
bz

Group Reviewers

Commits

rGb71805e991fb: rtwn: add APIs for setting transmit power

Summary

The RTL8188/RTL8192/RTL8821/RTL8812 NICs all seem happy to have
their transmit power changed at runtime - and it does seem to do
what's expected - the transmit power level does change.

So, add the API call here, even though it's all currently no-ops.
A follow-up commit will land changes for the chipsets to both
limit transmit power to the configured / regulatory limit AND
allow reconfiguration at runtime.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 7 2024, 4:34 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 7 2024, 4:34 PM

adrian requested review of this revision.Dec 7 2024, 4:34 PM

Harbormaster completed remote builds in B61025: Diff 147681.Dec 7 2024, 4:34 PM

adrian added a parent revision: D47978: rtwn: add tx power training for RTL8812/RTL8821.Dec 7 2024, 4:34 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D47986: rtwn: refactor out the TX power register power dump, condense output.Dec 8 2024, 3:49 PM

imp accepted this revision.Thu, Dec 12, 6:17 PM

This revision is now accepted and ready to land.Thu, Dec 12, 6:17 PM

I think at least r92eu_attach is lacking the default initialization?

This revision now requires changes to proceed.Wed, Dec 18, 10:29 AM

bz mentioned this in D47987: rtwn: try enforcing net80211 regulatory / txpower limits for 11n chips.Wed, Dec 18, 10:41 AM

from bz - add missing init

Harbormaster completed remote builds in B61238: Diff 148201.Wed, Dec 18, 4:46 PM

In D47979#1097408, @bz wrote:

I think at least r92eu_attach is lacking the default initialization?

fixed, good catch!

(I added the initialiser in a later commit in the stack, which is why I didn't catch it here..)

update from another rebase attempt

Harbormaster completed remote builds in B61240: Diff 148203.Wed, Dec 18, 5:04 PM

update from rebase

Harbormaster completed remote builds in B61251: Diff 148217.Wed, Dec 18, 9:53 PM

bz accepted this revision.Wed, Dec 18, 9:58 PM

This revision is now accepted and ready to land.Wed, Dec 18, 9:58 PM

Closed by commit rGb71805e991fb: rtwn: add APIs for setting transmit power (authored by adrian). · Explain WhyWed, Dec 18, 11:49 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGb71805e991fb: rtwn: add APIs for setting transmit power.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

9 lines

6 lines

4 lines

rtl8188e/

pci/

1 line

usb/

1 line

rtl8192c/

pci/

1 line

usb/

1 line

rtl8192e/

usb/

1 line

rtl8812a/

usb/

1 line

rtl8821a/

usb/

1 line

Diff 148221

sys/dev/rtwn/if_rtwn.c

Loading...

sys/dev/rtwn/if_rtwn_nop.h

Loading...

sys/dev/rtwn/if_rtwnvar.h

Loading...

sys/dev/rtwn/rtl8188e/pci/r88ee_attach.c

Loading...

sys/dev/rtwn/rtl8188e/usb/r88eu_attach.c

Loading...

sys/dev/rtwn/rtl8192c/pci/r92ce_attach.c

Loading...

sys/dev/rtwn/rtl8192c/usb/r92cu_attach.c

Loading...

sys/dev/rtwn/rtl8192e/usb/r92eu_attach.c

Loading...

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c

Loading...

sys/dev/rtwn/rtl8821a/usb/r21au_attach.c

Loading...