Differential D47766

rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG
ClosedPublic
Actions

Authored by adrian on Nov 26 2024, 5:06 PM.

Details

Reviewers

Group Reviewers

wireless

Commits

rG77e64f45c478: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG

Summary

use ieee80211_ht_get_node_ampdu_density() now instead of the vap->iv_ampdu_density, so the correct density is used in AP/IBSS/mesh modes.

MAX_AGG controls how many frames are to be sent in an A-MPDU. It maps to ((MAX_AGG * 2) + 1) == npackets. 0x1f (31) means 64 packets. So, instead of hard-coding 0x1f, use the negotiated block-ack window size.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Nov 26 2024, 5:06 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 26 2024, 5:06 PM

adrian requested review of this revision.Nov 26 2024, 5:06 PM

Harbormaster completed remote builds in B60795: Diff 146991.Nov 26 2024, 5:06 PM

add url

Harbormaster completed remote builds in B60796: Diff 146992.Nov 26 2024, 5:07 PM

adrian added a parent revision: D47755: iwn: use ieee80211_ht_check_tx_ht().Nov 26 2024, 5:07 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D47774: rtwn: fix rtl8812/rtl8821 vht definitions, add VHT calibration/rate control.Nov 27 2024, 12:08 AM

bz requested changes to this revision.Nov 28 2024, 1:00 AM

bz added a subscriber: bz.

bz added inline comments.

sys/dev/rtwn/rtl8192c/r92c_tx.c
300	If you do the assignment outside the declaration you don't have to wrap; also you can do it when you need it. (same in the other file)

This revision now requires changes to proceed.Nov 28 2024, 1:00 AM

pull window calc code into their own routines

Harbormaster completed remote builds in B60909: Diff 147341.Dec 2 2024, 6:51 AM

ok, please re-review!

adrian marked an inline comment as done.Dec 2 2024, 7:18 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 5 2024, 7:31 AM

Closed by commit rG77e64f45c478: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG77e64f45c478: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

rtl8192c/

r92c_tx.c

26 lines

rtl8812a/

r12a_tx.c

26 lines

Diff 147520

View Options

sys/dev/rtwn/rtl8192c/r92c_tx.c