Differential D48066

rtwn: create a new HAL routine for enabling STA mode beacon processing
ClosedPublic
Actions

Authored by adrian on Dec 13 2024, 4:12 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Dec 26, 2:11 AM

	Unknown Object (File)
	Wed, Dec 25, 12:13 PM

	Unknown Object (File)
	Wed, Dec 25, 11:25 AM

	Unknown Object (File)
	Wed, Dec 25, 11:20 AM

	Unknown Object (File)
	Wed, Dec 25, 7:31 AM

	Unknown Object (File)
	Sun, Dec 22, 8:19 PM

	Unknown Object (File)
	Sun, Dec 22, 1:52 AM

	Unknown Object (File)
	Fri, Dec 20, 8:41 PM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG9efd215411bb: rtwn: create a new HAL routine for enabling STA mode beacon processing

Summary

For some NICs (notably the rtl8192cu that I'm working on) the
firmware rate adaptation requires beacon processing to be enabled.

Instead of making assumptions in the if_rtwn beacon routines (and
honestly all of that should be in the HAL too), create a HAL method
for enabling/disabling beacon processing specifically in STA mode.

Since this isn't necessarily required for all NICs (notably the RTL8188E
NICs, where some will do firmware rate control and some will require
driver rate control), only enable it for the RTL8192CU and RT8192EU.

The RTL8188E and RTL8812/RTL8821 just have no-op routines for now.

Locally tested:

RTL8192CU, STA mode

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 13 2024, 4:12 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2024, 4:12 AM

adrian requested review of this revision.Dec 13 2024, 4:12 AM

Harbormaster completed remote builds in B61134: Diff 147909.Dec 13 2024, 4:12 AM

adrian added a parent revision: D48026: rtwn: disable a workaround introduced earlier for RTL8192CU TX performance.Dec 13 2024, 4:13 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D48067: rtwn: print out the firmware file being loaded.Dec 13 2024, 6:04 AM

bz requested changes to this revision.Wed, Dec 18, 12:55 PM

bz added a subscriber: bz.

bz added inline comments.

sys/dev/rtwn/rtl8192c/r92c_beacon.c
94	I'll mark it here for the entire file: "enable" is a bool; please use that in new code and no longer an int.

This revision now requires changes to proceed.Wed, Dec 18, 12:55 PM

use bool; requested by bz@

Harbormaster completed remote builds in B61249: Diff 148215.Wed, Dec 18, 9:53 PM

ok, try this!

Missed one but good apart from that; I'll trust you to fix this before commit. Thank you!

sys/dev/rtwn/rtl8192c/r92c_beacon.c
73	bool

bz requested changes to this revision.Thu, Dec 19, 10:46 AM

This revision now requires changes to proceed.Thu, Dec 19, 10:46 AM

adrian added inline comments.Thu, Dec 19, 3:49 PM

sys/dev/rtwn/rtl8192c/r92c_beacon.c
73	This is an existing routine, not a new one. I'll do a subsequent commit after this stack lands to clean the non-STA beacon API up!

emaste added a subscriber: emaste.Thu, Dec 19, 5:09 PM

emaste added inline comments.

sys/dev/rtwn/rtl8192c/r92c_beacon.c
73	I think including a change to bool on this would be fine rolled into this commit, but it doesn't really matter, fine as a subsequent cleanup too.

bz accepted this revision.Thu, Dec 19, 5:14 PM

bz added inline comments.

sys/dev/rtwn/rtl8192c/r92c_beacon.c
73	Sorry. My fault.

This revision is now accepted and ready to land.Thu, Dec 19, 5:14 PM

Closed by commit rG9efd215411bb: rtwn: create a new HAL routine for enabling STA mode beacon processing (authored by adrian). · Explain WhyFri, Dec 20, 8:41 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG9efd215411bb: rtwn: create a new HAL routine for enabling STA mode beacon processing.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

3 lines

4 lines

rtl8188e/

pci/

1 line

1 line

12 lines

usb/

1 line

rtl8192c/

pci/

1 line

1 line

20 lines

usb/

1 line

rtl8192e/

usb/

1 line

rtl8812a/

1 line

9 lines

usb/

1 line

rtl8821a/

usb/

1 line

Diff 148297

sys/dev/rtwn/if_rtwn.c

Loading...

sys/dev/rtwn/if_rtwnvar.h

Loading...

sys/dev/rtwn/rtl8188e/pci/r88ee_attach.c

Loading...

sys/dev/rtwn/rtl8188e/r88e.h

Loading...

sys/dev/rtwn/rtl8188e/r88e_beacon.c

Loading...

sys/dev/rtwn/rtl8188e/usb/r88eu_attach.c

Loading...

sys/dev/rtwn/rtl8192c/pci/r92ce_attach.c

Loading...

sys/dev/rtwn/rtl8192c/r92c.h

Loading...

sys/dev/rtwn/rtl8192c/r92c_beacon.c

Loading...

sys/dev/rtwn/rtl8192c/usb/r92cu_attach.c

Loading...

sys/dev/rtwn/rtl8192e/usb/r92eu_attach.c

Loading...

sys/dev/rtwn/rtl8812a/r12a.h

Loading...

sys/dev/rtwn/rtl8812a/r12a_beacon.c

Loading...

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c

Loading...

sys/dev/rtwn/rtl8821a/usb/r21au_attach.c

Loading...