Page MenuHomeFreeBSD

rtwn: add forcerate flag to TX descriptor setup
ClosedPublic

Authored by adrian on Dec 16 2024, 1:31 AM.
Referenced Files
Unknown Object (File)
Fri, Jan 3, 10:55 PM
Unknown Object (File)
Fri, Jan 3, 3:59 AM
Unknown Object (File)
Thu, Dec 26, 7:14 AM
Unknown Object (File)
Dec 25 2024, 7:58 PM
Unknown Object (File)
Dec 25 2024, 11:22 AM
Unknown Object (File)
Dec 23 2024, 1:01 AM
Unknown Object (File)
Dec 22 2024, 2:48 AM
Unknown Object (File)
Dec 19 2024, 6:50 PM
Subscribers

Details

Summary

When doing firmware rate control there will be situations where
the rate being passed in needs to actually override the rate
control selection. So add a flag to the descriptor setup path
to indicate that indeed this particular rate should be forced,
rather than rely on the firmware rate control.

This is currently a no-op as firmware rate control isn't working
in-tree, but it is working for me locally with other changes.
Without this, there's no way to force low rates for management,
DHCP traffic, and to allow fixed rate via "ifconfig wlanX ucastrate Y"
to function.

Locally tested:

  • RTL8192CU, STA mode (firmware and driver/net80211 rate control)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This all seems fine to me

sys/dev/rtwn/if_rtwn_tx.c
134–141

Minor minor suggestion but just for symmetry, set rate and force_rate in the same order in each statement

This revision is now accepted and ready to land.Thu, Jan 2, 12:07 AM