Page MenuHomeFreeBSD
Differential D48102

rtwn: add VHT20/VHT40/VHT80 bandwidth configuration for transmit.
ClosedPublic
Actions

Authored by adrian on Mon, Dec 16, 2:36 AM.
Tags
Referenced Files
F107019995: D48102.diff
Thu, Jan 9, 1:57 AM
Unknown Object (File)
Thu, Dec 26, 4:26 AM
Unknown Object (File)
Wed, Dec 25, 11:26 AM
Unknown Object (File)
Wed, Dec 25, 10:39 AM
Unknown Object (File)
Wed, Dec 25, 12:59 AM
Unknown Object (File)
Tue, Dec 24, 12:58 AM
Unknown Object (File)
Mon, Dec 23, 10:21 AM
Unknown Object (File)
Thu, Dec 19, 7:17 PM
Subscribers
bz
emaste
fuz
imp

Details

Reviewers
None
Group Reviewers
wireless
Commits
rG82182587bcc3: rtwn: add VHT20/VHT40/VHT80 bandwidth configuration for transmit.
Summary

Add a separate function and path for VHT 20/40/80MHz bandwidth
transmission.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Mon, Dec 16, 2:36 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Dec 16, 2:36 AM
adrian requested review of this revision.Mon, Dec 16, 2:36 AM
Harbormaster completed remote builds in B61191: Diff 148004.Mon, Dec 16, 2:36 AM
adrian added a parent revision: D48101: net80211: add helper functions for VHT transmit.Mon, Dec 16, 2:36 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D48103: rtwn: announce VHT support for RTL8812AU/RTL8821AU..Mon, Dec 16, 4:18 AM
fuz added a subscriber: fuz.Thu, Dec 26, 9:18 PM

Looks reasonable.

sys/dev/rtwn/rtl8812a/r12a_tx.c
127

Redundant empty line?

adrian updated this revision to Diff 148630.Tue, Dec 31, 9:40 PM

feedback from fuz, cleanup, comment

Harbormaster completed remote builds in B61440: Diff 148630.Tue, Dec 31, 9:40 PM
bz added a subscriber: bz.Thu, Jan 2, 1:07 PM

I'll wait with this one as D48101 will likely change the KPI.

adrian updated this revision to Diff 148711.Fri, Jan 3, 12:45 AM

update!

Harbormaster completed remote builds in B61473: Diff 148711.Fri, Jan 3, 12:45 AM
adrian updated this revision to Diff 148937.Wed, Jan 8, 6:24 PM

rebase

Harbormaster completed remote builds in B61577: Diff 148937.Wed, Jan 8, 6:24 PM
emaste added a subscriber: emaste.Wed, Jan 8, 7:36 PM
emaste added inline comments.
sys/dev/rtwn/rtl8812a/r12a_tx.c
94

Out of curiosity is there a reason someone would assume otherwise? I don't have all of the context but I would assume ...tx_set_vht_bw is called for vht.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jan 9, 1:00 AM
Closed by commit rG82182587bcc3: rtwn: add VHT20/VHT40/VHT80 bandwidth configuration for transmit. (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG82182587bcc3: rtwn: add VHT20/VHT40/VHT80 bandwidth configuration for transmit..

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8812a/
41 lines

Diff 148960

View Options

sys/dev/rtwn/rtl8812a/r12a_tx.c

Loading...