kernel: Fix defining of .init_array and .fini_array sections
ClosedPublic
Actions

Authored by zlei on May 14 2024, 4:24 AM.

Details

Reviewers

emaste
arichardson
dim
imp

Commits

rG87841ead405f: kernel: Fix defining of .init_array and .fini_array sections
rG1d94490aee5c: kernel: Fix defining of .init_array and .fini_array sections
rGe15b5ba77d69: kernel: Fix defining of .init_array and .fini_array sections

Summary

These input sections can have decimal numbers as the priority suffix.
SORT is an alias for SORT_BY_NAME, hence will result in wrong order of
constructors / destructors in output sections. Fix by using the correct
sorting command SORT_BY_INIT_PRIORITY instead [1].

If the input section does not have a priority suffix, then it should be
treated as having a priority of 65535.

Currently these sections are not used, there should be no functional
change.

Note: As for the .ctors and .dtors sections, the priority suffix is in
the form of %05u so there is no semantic difference between SORT_BY_NAME
and SORT_BY_INIT_PRIORITY [2].

In memoriam: hselasky
Obtained from: https://reviews.freebsd.org/D40467
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.May 14 2024, 4:24 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2024, 4:24 AM

zlei requested review of this revision.May 14 2024, 4:24 AM

zlei mentioned this in D40467: ld(1): Correctly define .init_array and .fini_array for all platforms..May 14 2024, 4:27 AM

Other arch? At the very least a lube in the commit about why not relevant there

This revision is now accepted and ready to land.May 14 2024, 12:54 PM

S/lube/line/. Stupid autocowrecked

In D45194#1030970, @imp wrote:

Other arch? At the very least a lube in the commit about why not relevant there

This is split from D40467 and is the FIX for existing amd64 and i386 arch. This is definitely the right fix so I'd expect it can be landed quickly.
I'm going to update D40467 to only add .init_array and .fini_array sections for other arch (but this fix).

Then a quick line in yhe commit messafe saying its a fix

zlei retitled this revision from kernel: Correctly define .init_array and .fini_array sections to kernel: Fix defining of .init_array and .fini_array sections.May 15 2024, 2:46 AM

In D45194#1031125, @imp wrote:

Then a quick line in yhe commit messafe saying its a fix

Is the commit message kernel: Fix defining of .init_array and .fini_array sections sufficient ?

Yes

zlei added inline comments.May 16 2024, 3:39 AM

sys/conf/ldscript.amd64
104	While I was about to commit this, I found this issue. The functions referenced by section `.fini_array` is in the normal order, but been executed in the reverse order.