xen/control: introduce xen_pv_shutdown_handler()
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Mar 23 2021, 10:07 PM.

Details

Reviewers

royger
mhorne

Commits

rG0b4f30c2366c: xen/control: introduce xen_pv_shutdown_handler()

Summary

While x86 only register PV shutdown handler for PV guests. ARM guests
are always using HVM and requires the PV shutdown handler.

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-04-04 16:52:05

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ehem_freebsd_m5p.com created this revision.Mar 23 2021, 10:07 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2021, 10:07 PM

ehem_freebsd_m5p.com requested review of this revision.Mar 23 2021, 10:07 PM

Harbormaster completed remote builds in B38035: Diff 86229.Mar 23 2021, 10:07 PM

Just one minor comment.

sys/x86/include/xen/xen-os.h
53	Please drop the 'has' from the function name, as other similar functions just use xen_pv_foo format.

ehem_freebsd_m5p.com added a subscriber: julien_xen.org.Mar 30 2021, 6:47 PM

Removing the "has" from the function name as requested. Seems quite
appropriate.

Right place now. The difference should be sensible now.

Harbormaster completed remote builds in B38190: Diff 86570.Mar 30 2021, 7:01 PM

Sorry about the bandwidth from all these small changes. Review systems really need to do a bit more batching for e-mail messages.

ehem_freebsd_m5p.com mentioned this in D29498: xen/arm64: introduce sys/arm64/include/xen/xen-os.h.Mar 30 2021, 7:09 PM

ehem_freebsd_m5p.com added a parent revision: D29811: xen/xen-os: move inclusion of machine/xen-os.h later.Apr 17 2021, 5:45 PM

I discovered x86 needs D29811 first, but the requested change for D29406 has been done. Any news on this one?

royger accepted this revision.Apr 21 2021, 7:40 AM

This revision is now accepted and ready to land.Apr 21 2021, 7:40 AM

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

ehem_freebsd_m5p.com added a child revision: D29498: xen/arm64: introduce sys/arm64/include/xen/xen-os.h.Jul 3 2021, 12:40 AM

ehem_freebsd_m5p.com removed a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jul 3 2021, 12:43 AM

Closed by commit rG0b4f30c2366c: xen/control: introduce xen_pv_shutdown_handler() (authored by julien_xen.org, committed by royger). · Explain WhyJul 28 2021, 3:30 PM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG0b4f30c2366c: xen/control: introduce xen_pv_shutdown_handler().

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

control/

control.c

2 lines

x86/

include/

xen/

xen-os.h

7 lines

Diff 92876

View Options

sys/dev/xen/control/control.c