xen/intr: disable xen_intr_suspend() and xen_intr_resume() on !x86
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Jun 1 2021, 3:45 PM.

Details

Reviewers

royger
mhorne
julien_xen.org

Summary

Presently suspend/resume and migration aren't supported on Xen/!x86. As
such these functions won't be invoked. While merely 4 functions, this
does shrink the resultant kernel.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39646
Build 36535: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jun 1 2021, 3:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2021, 3:45 PM

ehem_freebsd_m5p.com requested review of this revision.Jun 1 2021, 3:45 PM

Harbormaster completed remote builds in B39646: Diff 90272.Jun 1 2021, 3:45 PM

ehem_freebsd_m5p.com added a parent revision: D30599: xen/intr: rework xen_intr_resume() for in-place remapping.Jun 1 2021, 3:47 PM

I'm now unsure of this. Originally this had been disabling x86-only functionality on other architectures, but the D30598 and D30599 make the current form of these functions build on other architectures. As such there is no longer an urgent need to disable them on other architectures, but they simply don't accomplish anything on non-x86.

Get the ordering right. This really needs D30236 to make sense; I've got it after D30599 in my tree, but there isn't any actual ordering issue with D30599.

Huh, this was still lying around. After a while I figured out how to adjust things work rather better.

Revision Contents
Changeset List

Path

Size

sys/

xen/

xen_intr.c

2 lines

Diff 90272

View Options

xen/intr: disable xen_intr_suspend() and xen_intr_resume() on !x86AbandonedPublicActions