I was looking at history and trying to figure out how things should look when submitted. Finally figured out, rather than introducing a near-empty sys/arm64/include/intr_machdep.h file, what is actually needed is to get rid of references to machine/intr_machdep.h. Now an issue of purging references to it, while ensuring I don't break anything (erk!).

So, these files still contain references to definitions provided by intr_machdep.h? Do you know which ones/how many?

Since test build (arm64, amd64 and i386) succeeded, I believe the #include of the header was the last remaining reference.

sys/dev/xen/control/control.c is rather messier (D29306 and D29599).

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

Any chance of review for D29959?

Yes, making these 3 files properly architecture-independent is as simple as removing the #include of this header. This might have been needed in the past (most likely due to earlier version of the event channel code), but now the #include is the last architecture-dependent bit.

This is not merely cleanup, there is genuine functional change. This header doesn't exist on other architectures (notably arm64) and so removing it allows these to build (and function) on other architectures.

ehem_freebsd_m5p.com mentioned this in D30950: xen/arm64: enable arm64 Xen configuration.Sep 4 2021, 3:46 AM

This seems fine, these drivers use the xen_intr_ interfaces rather than anything contained in the header. Just one question about pcifront.c.

sys/dev/xen/pcifront/pcifront.c
55 ↗	(On Diff #88067)	Hmm it seems like this file is not hooked up to the build. @royger should it be?

This revision is now accepted and ready to land.Oct 12 2021, 1:19 AM

LGTM, will push

sys/dev/xen/pcifront/pcifront.c
55 ↗	(On Diff #88067)	Not really, this was part of a very old Xen import but pcifront is only used for PV and FreeBSD doesn't support that mode.This code has never been built and should be purged. I can remove it when pushing this patch.

mhorne added inline comments.Oct 15 2021, 4:09 PM

sys/dev/xen/pcifront/pcifront.c
55 ↗	(On Diff #88067)	Cool, removing code is always the best result :)

ehem_freebsd_m5p.com added inline comments.Oct 16 2021, 1:42 AM

sys/dev/xen/pcifront/pcifront.c
55 ↗	(On Diff #88067)	As long as functionality is maintained. I note some workloads offer better performance in PV mode. PV mode though requires significant changes closer to the core. PV mode is still supported by Linux, but that may get more funding from Citrix.

royger added inline comments.Oct 20 2021, 10:34 AM

sys/dev/xen/pcifront/pcifront.c
55 ↗	(On Diff #88067)	FWIW it's mostly SuSE the one that currently has the maintainership burden of classic PV on Linux (and Xen support for Linux in general).