Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (523 w, 1 d)

Recent Activity

Fri, May 17

andrew committed rG457fa0f69ce0: arm64: Support break and watch points in VHE (authored by andrew).
arm64: Support break and watch points in VHE
Fri, May 17, 4:13 PM
andrew committed rGe72c41772352: arm: Use the correct irq when in the hypervisor (authored by andrew).
arm: Use the correct irq when in the hypervisor
Fri, May 17, 4:13 PM
andrew committed rGf715e95461c9: arm: Add a missing interrupt to the generic timer (authored by andrew).
arm: Add a missing interrupt to the generic timer
Fri, May 17, 4:13 PM
andrew closed D45121: arm64: Support break and watch points in VHE.
Fri, May 17, 4:13 PM
andrew closed D43975: arm: Use the correct irq when in the hypervisor.
Fri, May 17, 4:13 PM
andrew committed rG097bd33dd7a6: uart: DBG2 support to find the debug uart (authored by andrew).
uart: DBG2 support to find the debug uart
Fri, May 17, 4:13 PM
andrew closed D43974: arm: Add a missing interrupt to the generic timer.
Fri, May 17, 4:13 PM
andrew closed D44359: uart: DBG2 support to find the debug uart.
Fri, May 17, 4:13 PM
andrew committed rG4f8ba1c9dd00: arm64: add CONTEXTIDR_EL1 reg (authored by zachary.leaf_arm.com).
arm64: add CONTEXTIDR_EL1 reg
Fri, May 17, 3:13 PM
andrew committed rG10b3eac88db6: arm64: add PMBSR_MSS_{BSC,FSC} status code field (authored by zachary.leaf_arm.com).
arm64: add PMBSR_MSS_{BSC,FSC} status code field
Fri, May 17, 3:12 PM
andrew committed rGf7bdaa103eb8: arm64: make SPE regs use ALT_NAME macro (authored by zachary.leaf_arm.com).
arm64: make SPE regs use ALT_NAME macro
Fri, May 17, 3:12 PM
andrew closed D45173: arm64: add CONTEXTIDR_EL1 reg.
Fri, May 17, 3:12 PM
andrew closed D45172: arm64: add PMBSR_MSS_{BSC,FSC} status code field.
Fri, May 17, 3:12 PM
andrew closed D45171: arm64: make SPE regs use ALT_NAME macro.
Fri, May 17, 3:12 PM
andrew committed rG2790ff21452f: dev/psci: Fix a function name (authored by andrew).
dev/psci: Fix a function name
Fri, May 17, 1:22 PM
andrew committed rG4660d9658710: arm64/vmm: Fix the build with GCC (authored by andrew).
arm64/vmm: Fix the build with GCC
Fri, May 17, 1:22 PM
andrew added a reverting change for rG9e48c30e25a7: rtld: Add arm64 variant pcs tests: rG2228d7c5998b: Revert "rtld: Add arm64 variant pcs tests".
Fri, May 17, 11:21 AM
andrew committed rG2228d7c5998b: Revert "rtld: Add arm64 variant pcs tests" (authored by andrew).
Revert "rtld: Add arm64 variant pcs tests"
Fri, May 17, 11:20 AM
andrew added a reverting change for D44870: rtld: Add arm64 variant pcs tests: rG2228d7c5998b: Revert "rtld: Add arm64 variant pcs tests".
Fri, May 17, 11:20 AM
andrew committed rGcd3681011001: arm64: Use the _REG macros to read ID registers (authored by andrew).
arm64: Use the _REG macros to read ID registers
Fri, May 17, 10:23 AM
andrew closed D45177: arm64: Use the _REG macros to read ID registers.
Fri, May 17, 10:23 AM
andrew committed rGd6d860c7ff5c: arm64: Add MRS_REG_ALT_NAME ID register macros (authored by andrew).
arm64: Add MRS_REG_ALT_NAME ID register macros
Fri, May 17, 10:23 AM
andrew closed D45176: arm64: Add MRS_REG_ALT_NAME ID register macros.
Fri, May 17, 10:23 AM
andrew committed rG1cd90a2c16dd: rtld: Move powerpc specific code to powerpc files (authored by andrew).
rtld: Move powerpc specific code to powerpc files
Fri, May 17, 10:23 AM
andrew closed D45182: rtld: Move powerpc specific code to powerpc files.
Fri, May 17, 10:23 AM
andrew committed rG9e48c30e25a7: rtld: Add arm64 variant pcs tests (authored by andrew).
rtld: Add arm64 variant pcs tests
Fri, May 17, 10:23 AM
andrew closed D44870: rtld: Add arm64 variant pcs tests.
Fri, May 17, 10:23 AM
andrew committed rGd51fa0a9b11d: rtld: Add support for arm64 variant pcs (authored by andrew).
rtld: Add support for arm64 variant pcs
Fri, May 17, 10:23 AM
andrew closed D44869: rtld: Add support for arm64 variant pcs.
Fri, May 17, 10:22 AM
andrew committed rGdd4155bec744: rtld: Add arch_digest_dynamic (authored by andrew).
rtld: Add arch_digest_dynamic
Fri, May 17, 10:22 AM
andrew closed D45117: rtld: Add arch_digest_dynamic.
Fri, May 17, 10:22 AM
andrew closed D45116: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry.
Fri, May 17, 10:22 AM
andrew committed rG06db20ffeca9: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry (authored by andrew).
rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry
Fri, May 17, 10:22 AM
andrew closed D42229: rtld: Teach rtld about the BTI elf note.

Looks like I put the wrong review link in rG5270cc9757fb4e0c1303ec44c2602b75acf3806d

Fri, May 17, 9:31 AM

Wed, May 15

andrew accepted D45193: arm: fail early on gcc builds.

I have a few fixes for some of the build issues with gcc, but c++ bits of world and kernel modules are broken.

Wed, May 15, 10:14 AM

Tue, May 14

andrew accepted D45171: arm64: make SPE regs use ALT_NAME macro.
Tue, May 14, 10:00 AM
andrew accepted D45172: arm64: add PMBSR_MSS_{BSC,FSC} status code field.
Tue, May 14, 10:00 AM
andrew accepted D45173: arm64: add CONTEXTIDR_EL1 reg.
Tue, May 14, 10:00 AM
andrew updated the diff for D45117: rtld: Add arch_digest_dynamic.

Update the comment

Tue, May 14, 9:25 AM

Mon, May 13

andrew added a comment to D45182: rtld: Move powerpc specific code to powerpc files.

Untested, but looks correct based on earlier changes from @jhibbits

Mon, May 13, 6:19 PM
andrew requested review of D45182: rtld: Move powerpc specific code to powerpc files.
Mon, May 13, 6:19 PM
andrew accepted D45160: arm64_pmap: narrow scope of bti_same test.
Mon, May 13, 6:05 PM
andrew updated subscribers of D45116: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry.
Mon, May 13, 4:23 PM
andrew added inline comments to D45160: arm64_pmap: narrow scope of bti_same test.
Mon, May 13, 4:20 PM
andrew requested review of D45177: arm64: Use the _REG macros to read ID registers.
Mon, May 13, 3:23 PM
andrew requested review of D45176: arm64: Add MRS_REG_ALT_NAME ID register macros.
Mon, May 13, 3:22 PM
andrew added inline comments to D45171: arm64: make SPE regs use ALT_NAME macro.
Mon, May 13, 1:30 PM
andrew added inline comments to D45172: arm64: add PMBSR_MSS_{BSC,FSC} status code field.
Mon, May 13, 11:54 AM
andrew added inline comments to D45171: arm64: make SPE regs use ALT_NAME macro.
Mon, May 13, 11:35 AM
andrew added inline comments to D45173: arm64: add CONTEXTIDR_EL1 reg.
Mon, May 13, 11:34 AM

Fri, May 10

andrew committed rG634dd430b966: arm64: Update the page table list in locore (authored by andrew).
arm64: Update the page table list in locore
Fri, May 10, 9:32 AM
andrew committed rG719908c81300: arm64: Merge common page table creation code (authored by andrew).
arm64: Merge common page table creation code
Fri, May 10, 9:32 AM
andrew closed D45061: arm64: Merge common page table creation code.
Fri, May 10, 9:32 AM
andrew committed rG4ab0f5ab3fd6: arm64/gicv3: Check if the hardware supports LPIs (authored by andrew).
arm64/gicv3: Check if the hardware supports LPIs
Fri, May 10, 9:32 AM
andrew closed D44914: arm64/gicv3: Check if the hardware supports LPIs.
Fri, May 10, 9:31 AM
andrew closed D44913: dev/psci: Check all compat strings.
Fri, May 10, 9:31 AM
andrew committed rGf91e9401c209: dev/psci: Check all compat strings (authored by andrew).
dev/psci: Check all compat strings
Fri, May 10, 9:31 AM
andrew closed D45083: arm64: Flush the spintable release address.
Fri, May 10, 9:31 AM
andrew committed rG797f1c7c3dea: arm64: Flush the spintable release address (authored by andrew).
arm64: Flush the spintable release address
Fri, May 10, 9:31 AM
andrew closed D45082: arm64: Support a shared release for spin-table.
Fri, May 10, 9:31 AM
andrew committed rGc78ebc69c2aa: arm64: Support a shared release for spin-table (authored by andrew).
arm64: Support a shared release for spin-table
Fri, May 10, 9:31 AM
andrew closed D45081: am64: Allow cpu.h to be included from assembly.
Fri, May 10, 9:30 AM
andrew committed rGe353ac0cfd5d: am64: Allow cpu.h to be included from assembly (authored by andrew).
am64: Allow cpu.h to be included from assembly
Fri, May 10, 9:30 AM

Wed, May 8

andrew added inline comments to D44740: bhyve: Add arm64 support to the gdb stub.
Wed, May 8, 7:41 PM
andrew requested review of D45121: arm64: Support break and watch points in VHE.
Wed, May 8, 12:28 PM

Tue, May 7

andrew updated the diff for D44869: rtld: Add support for arm64 variant pcs.

Rebase on new macros

Tue, May 7, 4:38 PM
andrew requested review of D45117: rtld: Add arch_digest_dynamic.
Tue, May 7, 4:36 PM
andrew requested review of D45116: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry.
Tue, May 7, 4:36 PM

Fri, May 3

andrew requested review of D45083: arm64: Flush the spintable release address.
Fri, May 3, 4:24 PM
andrew requested review of D45082: arm64: Support a shared release for spin-table.
Fri, May 3, 4:24 PM
andrew requested review of D45081: am64: Allow cpu.h to be included from assembly.
Fri, May 3, 4:24 PM
andrew added inline comments to D45065: param.h: Add PAGE_SIZE_MAX and PAGE_SHIFT_MAX.
Fri, May 3, 9:17 AM

Thu, May 2

andrew added a comment to D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.

See D45065 (and D45066 for a use in getpagesize & getpagesizes)

Thu, May 2, 4:39 PM
andrew requested review of D45066: libsys: Fall back to the worst case page size.
Thu, May 2, 4:38 PM
andrew requested review of D45065: param.h: Add PAGE_SIZE_MAX and PAGE_SHIFT_MAX.
Thu, May 2, 4:38 PM
andrew requested review of D45064: arm64: Create an L3 table to limit permissions.
Thu, May 2, 4:10 PM
andrew requested review of D45063: arm64: Reduce the kernel executable pages.
Thu, May 2, 4:10 PM
andrew requested review of D45062: arm64: Use tables to find early page tables.
Thu, May 2, 4:09 PM
andrew requested review of D45061: arm64: Merge common page table creation code.
Thu, May 2, 4:09 PM
andrew added a comment to D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.

I've been thinking about adding PAGE_SIZE_MAX/PAGE_SHIFT_MAX or similar to arm64 to define the largest page size the kernel could support. We could then use that here if it's defined.

Thu, May 2, 2:50 PM
andrew committed rGc3a3b231da00: arm64: Check DMAP address is valid in PHYS_IN_DMAP (authored by andrew).
arm64: Check DMAP address is valid in PHYS_IN_DMAP
Thu, May 2, 8:10 AM

Tue, Apr 30

andrew committed rGb91f2954bdc9: arm64: Check for virtio for scmi_virtio.c (authored by andrew).
arm64: Check for virtio for scmi_virtio.c
Tue, Apr 30, 9:09 AM

Mon, Apr 29

andrew accepted D44934: arm64/vmm: Handle VM_EXITCODE_SUSPENDED.
Mon, Apr 29, 9:04 AM

Wed, Apr 24

andrew committed rGd7ac42676dc4: elf_common.h: Add STO_AARCH64_VARIANT_PCS (authored by andrew).
elf_common.h: Add STO_AARCH64_VARIANT_PCS
Wed, Apr 24, 6:32 PM
andrew committed rG2c35c867ba05: showconfig: Set MACHINE for src.opts.mk (authored by andrew).
showconfig: Set MACHINE for src.opts.mk
Wed, Apr 24, 6:32 PM
andrew closed D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.
Wed, Apr 24, 6:32 PM
andrew committed rG9d40492efa46: arm64: Check DMAP address is valid in PHYS_IN_DMAP (authored by andrew).
arm64: Check DMAP address is valid in PHYS_IN_DMAP
Wed, Apr 24, 6:32 PM
andrew committed rGef80df0a7191: arm64/vmm: Ensure the tlbi has completed (authored by andrew).
arm64/vmm: Ensure the tlbi has completed
Wed, Apr 24, 6:32 PM
andrew closed D44838: showconfig: Set MACHINE for src.opts.mk.
Wed, Apr 24, 6:32 PM
andrew closed D44677: arm64: Check DMAP address is valid in PHYS_IN_DMAP.
Wed, Apr 24, 6:32 PM
andrew closed D44799: arm64/vmm: Ensure the tlbi has completed.
Wed, Apr 24, 6:32 PM
andrew added a comment to D42899: arm64: Make SMP `spin-table` boot method work for more than Apple Silicon.

I've thought about this and think we should only read ap_cpuid after the MMU is enabled. The same physical address should be mapped with the same memory type for all virtual addresses, however this isn't possible for ap_cpuid when the MMU is disabled.

Wed, Apr 24, 8:30 AM

Tue, Apr 23

andrew requested review of D44914: arm64/gicv3: Check if the hardware supports LPIs.
Tue, Apr 23, 2:58 PM
andrew requested review of D44913: dev/psci: Check all compat strings.
Tue, Apr 23, 2:58 PM
andrew added a comment to D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.

Do we need to add support to e.g. ELF Tool Chain readelf and nm to decode these values?

Tue, Apr 23, 9:24 AM
andrew added a comment to D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.

A flag. https://github.com/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst#st_other-values lists it under Processor specific st_other flags.

Tue, Apr 23, 9:19 AM

Apr 19 2024

andrew added inline comments to D44869: rtld: Add support for arm64 variant pcs.
Apr 19 2024, 4:22 PM
andrew updated the diff for D44869: rtld: Add support for arm64 variant pcs.
  • Fix a comment
  • Remove debugging
Apr 19 2024, 4:21 PM
andrew retitled D44869: rtld: Add support for arm64 variant pcs from rtld: Add suport for arm64 variant pcs to rtld: Add support for arm64 variant pcs.
Apr 19 2024, 3:56 PM
andrew added a comment to D44740: bhyve: Add arm64 support to the gdb stub.

Given it's a single instruction being written we could just ignore DIC & IDC, I expect the overhead would be less than a system call & this is an uncommon operation. We wouldn't even need to read ctr_el0 as the smallest cacheline size is the same as the instruction size.

Apr 19 2024, 3:55 PM