Page MenuHomeFreeBSD

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (522 w, 1 d)

Recent Activity

Today

kib added a comment to D45163: vm: Allow kstack pages to come from different domains.

What if you revert the order of allocation, first finding some domain which provides enough physical pages to back the stack, and then try to allocate KVA from corresponding arena?

Sun, May 19, 5:12 PM
kib added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Sun, May 19, 2:18 AM
kib added reviewers for D45244: Stop treating size 0 as unknown size in vnode_create_vobject().: markj, alc.
Sun, May 19, 1:30 AM
kib added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Sun, May 19, 1:30 AM
kib added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
Sun, May 19, 1:26 AM
kib committed rGe4df9d84b19f: vfs_domount_update(): style, use space instead of tab (authored by kib).
vfs_domount_update(): style, use space instead of tab
Sun, May 19, 1:00 AM
kib committed rG7c23465541f3: devfs_allocv(): style (authored by kib).
devfs_allocv(): style
Sun, May 19, 1:00 AM
kib committed rG2eeb0e9fc130: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once (authored by kib).
cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once
Sun, May 19, 1:00 AM
kib committed rG936aa8ec7cb5: vfs_domount_update(): style, use space instead of tab (authored by kib).
vfs_domount_update(): style, use space instead of tab
Sun, May 19, 12:59 AM
kib committed rG9ccd5394123b: devfs_allocv(): style (authored by kib).
devfs_allocv(): style
Sun, May 19, 12:59 AM
kib committed rG4018bcdea8e1: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once (authored by kib).
cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once
Sun, May 19, 12:59 AM

Yesterday

kib committed rGff4480baf6f1: nfs client comment typo fix (authored by kib).
nfs client comment typo fix
Sat, May 18, 10:52 PM
kib accepted D44271: bsd.lib.mk: add targets to detect symbol changes.
Sat, May 18, 7:55 PM

Fri, May 17

kib updated the diff for D45191: amd64: use INVLPGB for kernel pmap invalidations.

Use NPTEPG

Fri, May 17, 9:25 PM
kib updated the diff for D45191: amd64: use INVLPGB for kernel pmap invalidations.

+1 for maxcnt
remove cnt == 0 check

Fri, May 17, 4:27 PM
kib added inline comments to D45191: amd64: use INVLPGB for kernel pmap invalidations.
Fri, May 17, 4:27 PM

Thu, May 16

kib committed rG87a156527563: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information (authored by kib).
SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information
Thu, May 16, 5:54 PM
kib committed rG53725168e1b6: SysV SHM: move SHMSEG constants to sys/shm.h (authored by kib).
SysV SHM: move SHMSEG constants to sys/shm.h
Thu, May 16, 5:54 PM
kib closed D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Thu, May 16, 5:54 PM
kib updated the diff for D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.

Move SHMSEG symbols.

Thu, May 16, 3:34 PM
kib committed rG21ccdb4119af: vfs_domount_update(): postpone setting MNT_UNION until VFS_MOUNT() is done (authored by kib).
vfs_domount_update(): postpone setting MNT_UNION until VFS_MOUNT() is done
Thu, May 16, 1:02 AM
kib committed rG5a061a38cdfa: vfs_domount_update(): style, use space instead of tab (authored by kib).
vfs_domount_update(): style, use space instead of tab
Thu, May 16, 1:02 AM
kib closed D45208: vfs_domount_update(): postpone setting MNT_UNION until VFS_MOUNT() is done.
Thu, May 16, 1:02 AM

Wed, May 15

kib added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
Wed, May 15, 3:13 PM
kib committed rG6adfee18effb: sys/namei.h: move NI_CAP_VIOLATION() macro from namei.h to vfs_lookup.c (authored by kib).
sys/namei.h: move NI_CAP_VIOLATION() macro from namei.h to vfs_lookup.c
Wed, May 15, 1:22 PM
kib committed rG00cf2f3092e4: vfs_lookup.c: only call ktrcapfail() if KTRACE is enabled (authored by kib).
vfs_lookup.c: only call ktrcapfail() if KTRACE is enabled
Wed, May 15, 1:22 PM
kib requested review of D45208: vfs_domount_update(): postpone setting MNT_UNION until VFS_MOUNT() is done.
Wed, May 15, 10:02 AM
kib accepted D45196: mlx4, mlx5: Eliminate redundent check for NULL packet filter.

These two seems to be the only uses of if_getbpf() in the tree, unless I mis-grepped. Is this the cause for the change?

Wed, May 15, 3:53 AM
kib added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
Wed, May 15, 12:55 AM
kib updated the diff for D45191: amd64: use INVLPGB for kernel pmap invalidations.

Correct cnt, one more time.

Wed, May 15, 12:52 AM
kib accepted D45201: Enable soft updates by default for UFS2 filesystems.

I think it would be useful to have an option to disable SU, so that you still can format a volume with single command invocation regardless of SU enablement.

Wed, May 15, 12:44 AM

Tue, May 14

kib accepted D45084: uma: deduplicate uma_small_alloc.
Tue, May 14, 11:41 PM
kib updated the diff for D45191: amd64: use INVLPGB for kernel pmap invalidations.

Fix cnt calculation for 4k step in invlrng.
Flip default for invlpgb_works to 1.

Tue, May 14, 11:28 PM
kib added inline comments to D45191: amd64: use INVLPGB for kernel pmap invalidations.
Tue, May 14, 11:27 PM
kib committed rGc6113ac5a2c2: AMD CPUs: update bits and data from CPUID 0x8000_0008 (authored by kib).
AMD CPUs: update bits and data from CPUID 0x8000_0008
Tue, May 14, 11:07 PM
kib closed D45188: AMD CPUs: update bits and data from CPUID 0x8000_0008.
Tue, May 14, 11:07 PM
kib added inline comments to D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Tue, May 14, 10:28 PM
kib accepted D45117: rtld: Add arch_digest_dynamic.
Tue, May 14, 11:05 AM
kib committed rG338d53965d9f: x86: Add Intel TD/HFI related MSR/CPUID defines to specialregs.h (authored by koinec_yahoo.co.jp).
x86: Add Intel TD/HFI related MSR/CPUID defines to specialregs.h
Tue, May 14, 12:19 AM
kib closed D44453: coredirector - Intel TD/HFI driver - Part1: Add ITD/HFI related MSR/CPUID defines to specialregs.h.
Tue, May 14, 12:18 AM

Mon, May 13

kib updated the diff for D45188: AMD CPUs: update bits and data from CPUID 0x8000_0008.

Fix typo

Mon, May 13, 11:53 PM
kib added a comment to D45191: amd64: use INVLPGB for kernel pmap invalidations.

Not tested at all, machine is not yet available. I want to discuss this before debugging.

Mon, May 13, 11:35 PM
kib requested review of D45191: amd64: use INVLPGB for kernel pmap invalidations.
Mon, May 13, 11:34 PM
kib requested review of D45188: AMD CPUs: update bits and data from CPUID 0x8000_0008.
Mon, May 13, 11:26 PM
kib committed rG46811949797b: tmpfs_destroy_vobject(): clear v_object under the object lock (authored by kib).
tmpfs_destroy_vobject(): clear v_object under the object lock
Mon, May 13, 6:40 PM
kib committed rG6ada4e8a0ae9: swap-like pagers: assert that writemapping decrease does not pass zero (authored by kib).
swap-like pagers: assert that writemapping decrease does not pass zero
Mon, May 13, 6:35 PM
kib committed rG58d7ac11e77d: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode (authored by kib).
tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode
Mon, May 13, 6:35 PM
kib closed D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.
Mon, May 13, 6:34 PM
kib accepted D45182: rtld: Move powerpc specific code to powerpc files.

Thank you

Mon, May 13, 6:32 PM
kib updated the diff for D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Mon, May 13, 5:39 PM
kib accepted D45116: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry.
Mon, May 13, 4:30 PM
kib added a comment to D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.

The native FreeBSD ipcs command also uses these sysctl's.

Mon, May 13, 12:20 PM
kib updated the summary of D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Mon, May 13, 12:08 PM
kib requested review of D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Mon, May 13, 11:56 AM
kib committed rGddabe1d3c515: mlx5en: add diagnostic in one more case of failed eeprom read preparation (authored by kib).
mlx5en: add diagnostic in one more case of failed eeprom read preparation
Mon, May 13, 9:52 AM
kib committed rG9877b9bea5b0: mlx5en: add diagnostic in one more case of failed eeprom read preparation (authored by kib).
mlx5en: add diagnostic in one more case of failed eeprom read preparation
Mon, May 13, 9:52 AM

Sun, May 12

kib updated the diff for D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.

Do check for vp->v_object == NULL in writecount_recalc().

Sun, May 12, 9:11 AM
kib updated the diff for D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.
tmpfs_destroy_vobject(): clear v_object under the object lock
Sun, May 12, 1:31 AM
kib added a comment to D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.

Right. And finally, suppose that old > new and new != 0. Then we should not re-set OBJ_TMPFS_VREF in the else-case of the hunk you posted below.

Sun, May 12, 1:29 AM
kib committed rG6d79564fe341: devfs_allocv(): style (authored by kib).
devfs_allocv(): style
Sun, May 12, 1:16 AM
kib committed rGe93404065177: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once (authored by kib).
cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once
Sun, May 12, 1:16 AM
kib closed D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Sun, May 12, 1:15 AM

Sat, May 11

kib added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

For preloaded relocatable kernel module, I think the modification of loader is necessary as I discover SHT_NOTE section was not loaded by boot1 originally when the kernel module is preloaded.

This is most likely can/should be fixed by linker script.

Sat, May 11, 10:23 AM
kib added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

Thinking about it more, why does the loader change needed at all? Kernel parses/should parse the elf.

Sat, May 11, 10:03 AM
kib added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

It probably makes sense to split the change into two: one for loader, one for kernel.

Sat, May 11, 9:14 AM

Fri, May 10

kib accepted D45157: Increase IOAPIC_MAX_ID to 255 (from 254).
Fri, May 10, 6:16 PM
kib accepted D45156: vm: Change the return types of kernacc and useracc to bool.
Fri, May 10, 5:48 PM
kib accepted D45155: md: Merge two switch statements in mdstart_vnode.
Fri, May 10, 5:46 PM
kib updated the diff for D44220: mlx5en(4): inline IPSEC offload support.

Latest driver IPSEC support code.

Fri, May 10, 5:11 PM
kib added a comment to D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.
In D45119#1029542, @kib wrote:

I do not see how this solves the problem that @pho found. There, vm_map_process_deferred() was releasing writecounts, and in one case the backing vnode was doomed, so OBJ_TMPFS_VREF was clear.

Do you mean https://people.freebsd.org/~pho/stress/log/log0518.txt? I agree that this is different. But for me, log0518 states that clearing of OBJ_TMPFS_VREF and clearing of node->tn_vnode are not atomic (and really cannot be). So the assert "object with writable mappings does not have a reference" should be removed, because indeed vp might be in process of reclaim or the pointer to vp might be already invalid.

Yes, but that isn't sufficient. Consider that tmpfs_pager_writecount_recalc() will vrele() the vnode if the writecount drops to 0, which is incorrect if the TMPFS_VREF flag is already clear.

Fri, May 10, 5:07 PM
kib committed rG5cf78a550034: __cxa_thread_call_dtors(3): fix dtor pointer validity check (authored by kib).
__cxa_thread_call_dtors(3): fix dtor pointer validity check
Fri, May 10, 7:50 AM
kib committed rG6a8ca2ff5338: __cxa_thread_call_dtors(3): fix dtor pointer validity check (authored by kib).
__cxa_thread_call_dtors(3): fix dtor pointer validity check
Fri, May 10, 7:50 AM

Thu, May 9

kib accepted D45143: rtld-elf: Use a proper struct type for tlsdesc entries.
Thu, May 9, 8:06 PM
kib accepted D45142: uio: Use switch statements when handling UIO_READ vs UIO_WRITE.
Thu, May 9, 8:02 PM
kib updated the diff for D44219: ipsec_accel: kernel infrastructure.

Latest version after the rounds of bugfixes

Thu, May 9, 7:19 PM
kib added a comment to D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.

I do not see how this solves the problem that @pho found. There, vm_map_process_deferred() was releasing writecounts, and in one case the backing vnode was doomed, so OBJ_TMPFS_VREF was clear.

Thu, May 9, 5:16 PM

Wed, May 8

kib added inline comments to D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Wed, May 8, 7:00 PM
kib updated the diff for D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.

Reduce scope for object1 and color variables.
Assign OBJT_DEAD type to object before deallocating it on the path after failing ctr, since we do not want to have the device dtr called.

Wed, May 8, 6:38 PM
kib updated the diff for D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.

Use vm_object_deallocate() instead of _terminate() on cleanup path.
Defer OBJ_COLORED setting after ctr provides the color.

Wed, May 8, 5:54 PM
kib added a comment to D45058: linuxkpi: Fix arch_io_reserve_memtype_wc.

I spent yesterday and today on this but it's taking too much time to familiarise myself with the code so I won't be able to fix this in a timely manner. It's also too risky to make changes to drm-*-kmod this close to 14.1. So I've created D45125 which should be safe to MFC.

Are the following statements correct:

  • Physical RAM may be divided in segments with address ranges that are separated from each other.

Right

Wed, May 8, 4:34 PM
kib accepted D45125: linuxkpi: Make arch_io_*_memtype_wc amd64-only.
Wed, May 8, 4:16 PM
kib updated the diff for D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.

Remove refcount.h

Wed, May 8, 2:15 PM
kib accepted D45126: libthr: avoid varargs in fcntl and openat interposers.
Wed, May 8, 2:13 PM
kib updated subscribers of D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Wed, May 8, 2:09 PM
kib updated the diff for D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.

Remove invalid assert about zero writemappings of the object for the new vnode (since node might be old).
Add asserts that we do not underflow writemapping counters for swap pagers.

Wed, May 8, 2:04 PM
kib added inline comments to D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.
Wed, May 8, 2:02 PM
kib added a comment to D44306: linuxkpi: Provide a non-NULL value for THIS_MODULE.

I believe that would work and I agree it would be much simpler. @kib is there something the (b) variant provides that (a) would be missing if we went with @jhb's proposal? It seems like they provide the same functionality?

Wed, May 8, 9:32 AM
kib accepted D44869: rtld: Add support for arm64 variant pcs.
Wed, May 8, 3:58 AM
kib added inline comments to D45117: rtld: Add arch_digest_dynamic.
Wed, May 8, 3:57 AM
kib added inline comments to D45116: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry.
Wed, May 8, 3:56 AM
kib requested review of D45119: tmpfs: recalculate OBJ_TMPFS_VREF on reinstantiating node' vnode.
Wed, May 8, 3:10 AM

Tue, May 7

kib updated the diff for D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.

Check for object == NULL

Tue, May 7, 4:08 PM
kib added inline comments to D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Tue, May 7, 4:06 PM
kib updated the diff for D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.

Use vm_object_deallocate()

Tue, May 7, 2:47 PM
kib added inline comments to D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Tue, May 7, 2:46 PM
kib updated the diff for D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.

Handle first batch of comments.

Tue, May 7, 2:16 PM
kib added inline comments to D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Tue, May 7, 2:14 PM
kib requested review of D45113: cdev_pager_allocate(): ensure that the cdev_pager_ops ctr is called only once.
Tue, May 7, 1:27 PM
kib committed rGf73055ab1e2f: rtld.1: clarify interaction between -u and -o (authored by kib).
rtld.1: clarify interaction between -u and -o
Tue, May 7, 9:00 AM
kib committed rG10484ee13a36: rtld: add direct-exec option -o (authored by kib).
rtld: add direct-exec option -o
Tue, May 7, 9:00 AM