Page MenuHomeFreeBSD

umass: Document the ideal that it's better to fail bad commands
Needs ReviewPublic

Authored by imp on Mar 23 2025, 9:50 PM.
Tags
None
Referenced Files
F115928745: D49467.diff
Wed, Apr 30, 1:07 PM
Unknown Object (File)
Sat, Apr 5, 5:42 AM
Unknown Object (File)
Tue, Apr 1, 1:26 PM
Unknown Object (File)
Mon, Mar 31, 8:09 PM
Unknown Object (File)
Mar 29 2025, 9:32 AM
Unknown Object (File)
Mar 28 2025, 7:14 AM
Unknown Object (File)
Mar 28 2025, 12:46 AM
Unknown Object (File)
Mar 27 2025, 7:43 PM
Subscribers
None

Details

Reviewers
ken
mav
markj
chs
Summary

Generally, lying to the periph drivers about commands working is a bad
idea. They cannot get a global insight into the actual capacities of
the device when commands just work. There's good reason to intercept
bad commands at times, and to prevent the device from being exposed to
commands that, for example, hand the device. However, upper layer
periph drivers is the better place to cope with devices that don't
support the commands since it can make other inferences about the
device when it has wider knowledge.

But this represents a change in philosphy, so document that as
well. This shift happened for some commands a while ago. Many of the
quirks existed only to avoid whining errors on boot that were benign
and were a big burden. So da and cd slowly stopped the whining. Except
in cases where the command hangs the drive, we should limit new quirks
and avoid overly broad quirks (things work, but are less performant or
reliable, again mostly to avoid harmless errors that are no longer
printed).

Other sims will likely need some help with this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63074
Build 59958: arc lint + arc unit