Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F115928745
D49467.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
736 B
Referenced Files
None
Subscribers
None
D49467.diff
View Options
diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c
--- a/sys/dev/usb/storage/umass.c
+++ b/sys/dev/usb/storage/umass.c
@@ -2230,6 +2230,13 @@
* command format needed by the specific command set
* and return the converted command in
* "sc->sc_transfer.cmd_data"
+ *
+ * For commands we know the device doesn't support, we
+ * either complete them with an illegal request, or fake
+ * the completion, based on what upper layers tolerate.
+ * Ideally, we'd let the periph drivers know and not
+ * fake things up, but some periphs fall short of the
+ * ideal.
*/
if (umass_std_transform(sc, ccb, cmd, ccb->csio.cdb_len)) {
if (sc->sc_transfer.cmd_data[0] == INQUIRY) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, May 1, 1:07 PM (13 h, 31 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
17285216
Default Alt Text
D49467.diff (736 B)
Attached To
Mode
D49467: umass: Document the ideal that it's better to fail bad commands
Attached
Detach File
Event Timeline
Log In to Comment