umass: Simplify umass_std_transform to eliminate fake success
Needs ReviewPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 6, 1:16 PM

	Unknown Object (File)
	Sat, Apr 5, 5:47 AM

	Unknown Object (File)
	Sat, Apr 5, 1:15 AM

	Unknown Object (File)
	Mar 31 2025, 4:47 AM

	Unknown Object (File)
	Mar 31 2025, 4:47 AM

	Unknown Object (File)
	Mar 31 2025, 4:47 AM

	Unknown Object (File)
	Mar 31 2025, 4:47 AM

	Unknown Object (File)
	Mar 31 2025, 4:47 AM

View All 13 Files

Subscribers

None

Details

Reviewers

mav
ken
markj
chs

Summary

Now that nothing returns (2) to fake the success of the command,
eliminate that magic number by eliminating the case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63076
Build 59960: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63076: Diff 152568.Mar 23 2025, 9:50 PM

imp added a parent revision: D49468: umass: Fail SYNCHRONIZE_CACHE for UFI.Mar 23 2025, 9:50 PM

imp added a child revision: D49470: umass: make *_transform() return a bool.

imp added reviewers: mav, ken, markj.Mar 24 2025, 1:04 AM

imp added a reviewer: chs.Wed, Apr 2, 8:04 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

19 lines

Diff 152568

View Options

sys/dev/usb/storage/umass.c

umass: Simplify umass_std_transform to eliminate fake successNeeds ReviewPublicActions