umass: Move common code into umass_std_transform
Needs ReviewPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 5, 5:13 AM

	Unknown Object (File)
	Sat, Apr 5, 3:14 AM

	Unknown Object (File)
	Sat, Apr 5, 12:09 AM

	Unknown Object (File)
	Wed, Apr 2, 5:18 AM

	Unknown Object (File)
	Mar 29 2025, 4:52 PM

	Unknown Object (File)
	Mar 29 2025, 4:52 PM

	Unknown Object (File)
	Mar 29 2025, 4:52 PM

	Unknown Object (File)
	Mar 29 2025, 4:52 PM

View All 15 Files

Subscribers

nakayamakenjiro_gmail.com

Details

Reviewers

mav
markj
ken
chs

Summary

Move the length checks, and byte copying into umass_std_transform. The
copies are typically small and this simplifies the code a lot. Move
zeroing the buffer now to only when we change TEST UNIT READY to START
STOP.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63078
Build 59962: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63078: Diff 152570.Mar 23 2025, 9:50 PM

imp added a parent revision: D49470: umass: make *_transform() return a bool.Mar 23 2025, 9:50 PM

imp added a child revision: D49472: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform.

imp added reviewers: mav, nakayamakenjiro_gmail.com, markj.Mar 24 2025, 1:03 AM

LGTM, but could it be that I was assigned by mistake? I haven't submitted any patches around this part of the code.

In D49471#1128464, @nakayamakenjiro_gmail.com wrote:

LGTM, but could it be that I was assigned by mistake? I haven't submitted any patches around this part of the code.

Ah yes. It was by mistake, but thanks for the eyeballs and your time.

imp added a reviewer: chs.Wed, Apr 2, 8:05 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

54 lines

Diff 152570

View Options

sys/dev/usb/storage/umass.c

umass: Move common code into umass_std_transformNeeds ReviewPublicActions