Page MenuHomeFreeBSD

usb/quirks: Remove overly broad quirks
Needs ReviewPublic

Authored by imp on Sun, Mar 23, 9:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 10:09 AM
Unknown Object (File)
Fri, Mar 28, 4:16 PM
Unknown Object (File)
Fri, Mar 28, 2:46 PM
Unknown Object (File)
Fri, Mar 28, 1:27 PM
Unknown Object (File)
Fri, Mar 28, 1:27 PM
Unknown Object (File)
Fri, Mar 28, 1:27 PM
Unknown Object (File)
Fri, Mar 28, 1:27 PM
Unknown Object (File)
Fri, Mar 28, 1:27 PM
Subscribers
None

Details

Reviewers
markj
mav
ken
Summary

Now that we have a safe way to detect the vast majority of problems
with SYNCHRONIEZ CACHE, and since I have devices from many of these
vendors that work just fine (one of which will hang if you send it a
SYNCHROMIZE CACHE), I think these should all be reverted. The details
of when they were added are sketchy, the age of the devices in
question means these vendors have many generations of products after
and the general over-quirking of SYNCHRONIZE CACHE all point to just
removing them and adding back specific quirks should any need arise
after trying other means to debug.

Test Plan

This entire series has had the 50 or so old memory stocks, mp3 players, SATA adapters, CD PATA adapter, Floppy drives, PATA adapters tested with USB.
Also, ny normal systems with SAS drives are still happy.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63085
Build 59969: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sun, Mar 23, 9:51 PM
imp created this revision.

markj reports the apple one was added because the autoprobe code screwed up his ipad with rockbox firmware.
he'll test this series to see if that's fixed, but it failed due to all the sync cache at the start in that code, as outlined in the disabling message.

imp added reviewers: markj, mav, ken.