Differential D44243

libc/quad: narrow list of symbols exposed on i386
ClosedPublic
Actions

Authored by brooks on Mar 5 2024, 10:10 PM.

Details

Reviewers

kib

Commits

rG6e6cd03c911c: libc/quad: narrow list of symbols exposed on i386

Summary

These symbols aren't present on i386 so don't try to expose them.

Given the structure of quad/Makefile.inc, it might make more sense to
have per-arch symbol maps here, but this is sufficent to build with
WITHOUT_UNDEFINED_VERSION on i386.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56466
Build 53354: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 5 2024, 10:10 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 5 2024, 10:10 PM

brooks requested review of this revision.Mar 5 2024, 10:10 PM

Harbormaster completed remote builds in B56466: Diff 135432.Mar 5 2024, 10:10 PM

brooks added a parent revision: D44242: libc/i386: don't attempt to export alloca.Mar 5 2024, 10:10 PM

brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.Mar 5 2024, 10:10 PM

kib accepted this revision.Mar 6 2024, 8:07 AM

This revision is now accepted and ready to land.Mar 6 2024, 8:07 AM

Closed by commit rG6e6cd03c911c: libc/quad: narrow list of symbols exposed on i386 (authored by brooks). · Explain WhyMar 7 2024, 8:13 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG6e6cd03c911c: libc/quad: narrow list of symbols exposed on i386.

Revision Contents
Changeset List

Path

Size

lib/

libc/

quad/

Symbol.map

10 lines

Diff 135432

View Options

libc/quad: narrow list of symbols exposed on i386ClosedPublicActions