Page MenuHomeFreeBSD

riscv: remove more riscv64sf support
ClosedPublic

Authored by brooks on Mar 12 2024, 11:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 6:36 PM
Unknown Object (File)
Sat, Nov 9, 6:35 PM
Unknown Object (File)
Sat, Nov 9, 6:35 PM
Unknown Object (File)
Sat, Nov 9, 6:35 PM
Unknown Object (File)
Sat, Nov 9, 6:09 PM
Unknown Object (File)
Oct 6 2024, 5:53 AM
Unknown Object (File)
Oct 5 2024, 6:03 PM
Unknown Object (File)
Oct 5 2024, 12:48 AM
Subscribers

Details

Summary

Remove a few more bits of riscv64sf support in libc and libm.

Fixes: 1ca12bd927d7 Remove the riscv64sf architecture.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks retitled this revision from riscv: remove a more riscv64sf support to riscv: remove more riscv64sf support.Mar 12 2024, 11:21 PM
brooks added a reviewer: jhb.
lib/msun/riscv/fenv.h
73–76

Don't think we need to spend 10 lines of code to make the errors marginally more friendly. Arguably even this is unnecessary; you'll get an error from the linker if you mix different float ABIs, and crt* are hard float.

Drop __riscv_float_abi_soft in fenv.h

I think tis is good... not sure about jrtc's comments

This revision is now accepted and ready to land.Mar 13 2024, 1:57 AM
lib/msun/riscv/fenv.h
73–76

Yeah, I would just go with Jess' suggestion here.

lib/msun/riscv/fenv.h
73–76

So delete the whole block?

lib/msun/riscv/fenv.h
73–76

Either that or the suggested code block in Jess's comment that has a single #ifndef around an #error. I don't have a strong preference.

  • Squash with D44331
  • Reduce ABI checks as suggested
This revision now requires review to proceed.Mar 19 2024, 9:13 PM
This revision is now accepted and ready to land.Mar 21 2024, 6:51 PM
This revision was automatically updated to reflect the committed changes.