Page MenuHomeFreeBSD
Differential D45052

libgcc_s: __extendxftf2 and __trunctfxf2 are amd64-only
ClosedPublic
Actions

Authored by brooks on May 1 2024, 10:00 PM.
Tags
None
Referenced Files
F102449601: D45052.id137986.diff
Tue, Nov 12, 10:49 AM
Unknown Object (File)
Sat, Nov 9, 6:30 PM
Unknown Object (File)
Sat, Nov 9, 6:30 PM
Unknown Object (File)
Sat, Nov 9, 6:29 PM
Unknown Object (File)
Fri, Nov 8, 5:36 PM
Unknown Object (File)
Thu, Nov 7, 8:18 AM
Unknown Object (File)
Wed, Nov 6, 8:41 AM
Unknown Object (File)
Wed, Nov 6, 8:41 AM
View All 68 Files
Subscribers
emaste
imp

Details

Reviewers
arichardson
dim
emaste
Commits
rG723e60a278b1: libgcc_s: __extendxftf2 and __trunctfxf2 are amd64-only
Summary

extendxftf2 and trunctfxf2 build on amd64 not aarch64 and riscv.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.May 1 2024, 10:00 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 1 2024, 10:00 PM
brooks requested review of this revision.May 1 2024, 10:00 PM
Harbormaster completed remote builds in B57520: Diff 137986.May 1 2024, 10:00 PM
brooks mentioned this in D45034: libgcc_s: Don't build __extendxftf2 and __trunctfxf2.May 1 2024, 10:02 PM
brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.
brooks mentioned this in D44216: Make WITHOUT_UNDEFINED_VERSION the default.May 1 2024, 10:17 PM
arichardson added inline comments.May 2 2024, 6:28 AM
lib/libgcc_s/Symbol.map
225

Shouldn't this be an or? Although I'm not entirely sure if it builds for i386 since it needs int128.

emaste added a subscriber: emaste.May 2 2024, 12:25 PM
brooks retitled this revision from libgcc_s: __extendxftf2 and __trunctfxf2 are x86 symbols to libgcc_s: __extendxftf2 and __trunctfxf2 are amd64-only.May 2 2024, 4:19 PM
brooks edited the summary of this revision. (Show Details)
brooks updated this revision to Diff 138024.May 2 2024, 4:20 PM

These symbols are amd64-only

Harbormaster completed remote builds in B57547: Diff 138024.May 2 2024, 4:20 PM
brooks marked an inline comment as done.May 2 2024, 4:20 PM
brooks added inline comments.
lib/libgcc_s/Symbol.map
225

*sigh* how did this even compile?

emaste added inline comments.May 2 2024, 4:41 PM
lib/libgcc_s/Symbol.map
225

the source files for these are in a .if ${MACHINE_CPUARCH} == "amd64" || ${MACHINE_CPUARCH} == "i386" block in lib/libcompiler_rt/Makefile.inc?

brooks updated this revision to Diff 138029.May 2 2024, 5:01 PM
brooks marked an inline comment as done.

Avoid a couple compiler invocations to create empty object files

Harbormaster completed remote builds in B57550: Diff 138029.May 2 2024, 5:01 PM
brooks added inline comments.May 2 2024, 5:07 PM
lib/libgcc_s/Symbol.map
225

The pre-conditions aren't met when targeting i386 so the object files end up empty. I've tweaked the makefile to avoid those compiler invocations.

emaste accepted this revision.May 2 2024, 5:10 PM
This revision is now accepted and ready to land.May 2 2024, 5:10 PM
Closed by commit rG723e60a278b1: libgcc_s: __extendxftf2 and __trunctfxf2 are amd64-only (authored by brooks). · Explain WhyMay 2 2024, 5:15 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG723e60a278b1: libgcc_s: __extendxftf2 and __trunctfxf2 are amd64-only.

Revision Contents
Changeset List

PathSize
lib/
libcompiler_rt/
8 lines
libgcc_s/
10 lines

Diff 138031

View Options

lib/libcompiler_rt/Makefile.inc

Loading...
View Options

lib/libgcc_s/Symbol.map

Loading...