libsys: make __libsys_interposing static
ClosedPublic
Actions

Authored by brooks on Mar 5 2024, 9:51 PM.

Details

Reviewers

Commits

rGef5fddd3440c: libsys: make __libsys_interposing static

Summary

Access libsys_interposing with libsys_interposing_slot() in all
cases to support a move of these functions back to libc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56556
Build 53444: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 5 2024, 9:51 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 5 2024, 9:51 PM

brooks requested review of this revision.Mar 5 2024, 9:51 PM

Harbormaster completed remote builds in B56463: Diff 135429.Mar 5 2024, 9:51 PM

brooks added a parent revision: D44238: libsys: don't expose sigwait wrapper.Mar 5 2024, 9:51 PM

brooks added a child revision: D44241: lib{c,sys}: return wrapped syscall APIs to libc.

But may be __libc_interposing_slot() would serve same, if not better?

This revision is now accepted and ready to land.Mar 6 2024, 8:52 AM

Access all interposing slots via __libc_interposing_slot()
Actually dereference the slots rather than trying to jump to data...

This revision now requires review to proceed.Mar 12 2024, 9:00 PM

Harbormaster completed remote builds in B56556: Diff 135661.Mar 12 2024, 9:00 PM

kib accepted this revision.Mar 13 2024, 12:01 AM

This revision is now accepted and ready to land.Mar 13 2024, 12:01 AM

Closed by commit rGef5fddd3440c: libsys: make __libsys_interposing static (authored by brooks). · Explain WhyMar 13 2024, 6:37 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGef5fddd3440c: libsys: make __libsys_interposing static.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

libc_interposing_table.c

1 line

sleep.c

2 lines

usleep.c

2 lines

include/

libc_private.h

1 line

libsys/

2 lines

3 lines

3 lines

4 lines

2 lines

2 lines

4 lines

2 lines

3 lines

2 lines

2 lines

2 lines

4 lines

6 lines

2 lines

2 lines

4 lines

3 lines

3 lines

2 lines

4 lines

2 lines

2 lines

2 lines

4 lines

4 lines

2 lines

2 lines

2 lines

2 lines

4 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

3 lines

4 lines

3 lines

4 lines

4 lines

3 lines

2 lines

2 lines

Diff 135661

View Options

lib/libc/gen/libc_interposing_table.c

View Options

lib/libc/gen/sleep.c

View Options

lib/libc/gen/usleep.c

View Options

lib/libc/include/libc_private.h

View Options

lib/libsys/accept.c

View Options

lib/libsys/accept4.c

View Options

lib/libsys/aio_suspend.c

View Options

lib/libsys/clock_nanosleep.c

View Options

lib/libsys/close.c

View Options

lib/libsys/connect.c

View Options

lib/libsys/creat.c

View Options

lib/libsys/fcntl.c

View Options

lib/libsys/fdatasync.c

View Options

lib/libsys/fork.c

View Options

lib/libsys/fsync.c

View Options

lib/libsys/interposing_table.c

View Options

lib/libsys/kevent.c

View Options

lib/libsys/lockf.c

View Options

lib/libsys/msync.c

View Options

lib/libsys/nanosleep.c

View Options

lib/libsys/open.c

View Options

lib/libsys/openat.c

View Options

lib/libsys/pdfork.c

View Options

lib/libsys/poll.c

View Options

lib/libsys/ppoll.c

View Options

lib/libsys/pselect.c

View Options

lib/libsys/read.c

View Options

lib/libsys/readv.c

View Options

lib/libsys/recv.c

View Options

lib/libsys/recvfrom.c

View Options

lib/libsys/recvmsg.c

View Options

lib/libsys/select.c

View Options

lib/libsys/send.c

View Options

lib/libsys/sendmsg.c

View Options

lib/libsys/sendto.c

View Options

lib/libsys/setcontext.c

View Options

lib/libsys/sigaction.c

View Options

lib/libsys/sigprocmask.c

View Options

lib/libsys/sigsuspend.c

View Options

lib/libsys/sigtimedwait.c

View Options

lib/libsys/sigwait.c

View Options

lib/libsys/sigwaitinfo.c

View Options

lib/libsys/swapcontext.c

View Options

lib/libsys/wait.c

View Options

lib/libsys/wait3.c

View Options

lib/libsys/wait4.c

View Options

lib/libsys/wait6.c

View Options

lib/libsys/waitid.c

View Options

lib/libsys/waitpid.c

View Options

lib/libsys/write.c

View Options

libsys: make __libsys_interposing staticClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 135661

lib/libc/gen/libc_interposing_table.c

lib/libc/gen/sleep.c

lib/libc/gen/usleep.c

lib/libc/include/libc_private.h

lib/libsys/accept.c

lib/libsys/accept4.c

lib/libsys/aio_suspend.c

lib/libsys/clock_nanosleep.c

lib/libsys/close.c

lib/libsys/connect.c

lib/libsys/creat.c

lib/libsys/fcntl.c

lib/libsys/fdatasync.c

lib/libsys/fork.c

lib/libsys/fsync.c

lib/libsys/interposing_table.c

lib/libsys/kevent.c

lib/libsys/lockf.c

lib/libsys/msync.c

lib/libsys/nanosleep.c

lib/libsys/open.c

lib/libsys/openat.c

lib/libsys/pdfork.c

lib/libsys/poll.c

lib/libsys/ppoll.c

lib/libsys/pselect.c

lib/libsys/read.c

lib/libsys/readv.c

lib/libsys/recv.c

lib/libsys/recvfrom.c

lib/libsys/recvmsg.c

lib/libsys/select.c

lib/libsys/send.c

lib/libsys/sendmsg.c

lib/libsys/sendto.c

lib/libsys/setcontext.c

lib/libsys/sigaction.c

lib/libsys/sigprocmask.c

lib/libsys/sigsuspend.c

lib/libsys/sigtimedwait.c

lib/libsys/sigwait.c

lib/libsys/sigwaitinfo.c

lib/libsys/swapcontext.c

lib/libsys/wait.c

lib/libsys/wait3.c

lib/libsys/wait4.c

lib/libsys/wait6.c

lib/libsys/waitid.c

lib/libsys/waitpid.c

lib/libsys/write.c

lib/libsys/writev.c

libsys: make __libsys_interposing static
ClosedPublic
Actions

Revision Contents
Changeset List