Page MenuHomeFreeBSD
Differential D44239

libsys: make __libsys_interposing static
ClosedPublic
Actions

Authored by brooks on Mar 5 2024, 9:51 PM.
Tags
None
Referenced Files
F102575856: D44239.diff
Thu, Nov 14, 6:36 AM
Unknown Object (File)
Sat, Nov 9, 6:12 PM
Unknown Object (File)
Sat, Nov 9, 6:11 PM
Unknown Object (File)
Sat, Nov 9, 6:11 PM
Unknown Object (File)
Sat, Nov 9, 6:11 PM
Unknown Object (File)
Wed, Nov 6, 8:26 AM
Unknown Object (File)
Tue, Nov 5, 11:31 AM
Unknown Object (File)
Tue, Nov 5, 5:09 AM
View All 57 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGef5fddd3440c: libsys: make __libsys_interposing static
Summary

Access libsys_interposing with libsys_interposing_slot() in all
cases to support a move of these functions back to libc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56463
Build 53351: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 5 2024, 9:51 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 5 2024, 9:51 PM
brooks requested review of this revision.Mar 5 2024, 9:51 PM
Harbormaster completed remote builds in B56463: Diff 135429.Mar 5 2024, 9:51 PM
brooks added a parent revision: D44238: libsys: don't expose sigwait wrapper.Mar 5 2024, 9:51 PM
brooks added a child revision: D44241: lib{c,sys}: return wrapped syscall APIs to libc.
kib accepted this revision.Mar 6 2024, 8:52 AM

But may be __libc_interposing_slot() would serve same, if not better?

This revision is now accepted and ready to land.Mar 6 2024, 8:52 AM
brooks updated this revision to Diff 135661.Mar 12 2024, 9:00 PM
  • Access all interposing slots via __libc_interposing_slot()
  • Actually dereference the slots rather than trying to jump to data...
This revision now requires review to proceed.Mar 12 2024, 9:00 PM
Harbormaster completed remote builds in B56556: Diff 135661.Mar 12 2024, 9:00 PM
kib accepted this revision.Mar 13 2024, 12:01 AM
This revision is now accepted and ready to land.Mar 13 2024, 12:01 AM
Closed by commit rGef5fddd3440c: libsys: make __libsys_interposing static (authored by brooks). · Explain WhyMar 13 2024, 6:37 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGef5fddd3440c: libsys: make __libsys_interposing static.

Revision Contents
Changeset List

PathSize
lib/
libc/
include/
1 line
libsys/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 135429

View Options

lib/libc/include/libc_private.h

Loading...
View Options

lib/libsys/accept.c

Loading...
View Options

lib/libsys/accept4.c

Loading...
View Options

lib/libsys/aio_suspend.c

Loading...
View Options

lib/libsys/clock_nanosleep.c

Loading...
View Options

lib/libsys/close.c

Loading...
View Options

lib/libsys/connect.c

Loading...
View Options

lib/libsys/creat.c

Loading...
View Options

lib/libsys/fcntl.c

Loading...
View Options

lib/libsys/fdatasync.c

Loading...
View Options

lib/libsys/fork.c

Loading...
View Options

lib/libsys/fsync.c

Loading...
View Options

lib/libsys/interposing_table.c

Loading...
View Options

lib/libsys/kevent.c

Loading...
View Options

lib/libsys/lockf.c

Loading...
View Options

lib/libsys/msync.c

Loading...
View Options

lib/libsys/nanosleep.c

Loading...
View Options

lib/libsys/open.c

Loading...
View Options

lib/libsys/openat.c

Loading...
View Options

lib/libsys/pdfork.c

Loading...
View Options

lib/libsys/poll.c

Loading...
View Options

lib/libsys/ppoll.c

Loading...
View Options

lib/libsys/pselect.c

Loading...
View Options

lib/libsys/read.c

Loading...
View Options

lib/libsys/readv.c

Loading...
View Options

lib/libsys/recv.c

Loading...
View Options

lib/libsys/recvfrom.c

Loading...
View Options

lib/libsys/recvmsg.c

Loading...
View Options

lib/libsys/select.c

Loading...
View Options

lib/libsys/send.c

Loading...
View Options

lib/libsys/sendmsg.c

Loading...
View Options

lib/libsys/sendto.c

Loading...
View Options

lib/libsys/setcontext.c

Loading...
View Options

lib/libsys/sigaction.c

Loading...
View Options

lib/libsys/sigprocmask.c

Loading...
View Options

lib/libsys/sigsuspend.c

Loading...
View Options

lib/libsys/sigtimedwait.c

Loading...
View Options

lib/libsys/sigwait.c

Loading...
View Options

lib/libsys/sigwaitinfo.c

Loading...
View Options

lib/libsys/swapcontext.c

Loading...
View Options

lib/libsys/wait.c

Loading...
View Options

lib/libsys/wait3.c

Loading...
View Options

lib/libsys/wait4.c

Loading...
View Options

lib/libsys/wait6.c

Loading...
View Options

lib/libsys/waitid.c

Loading...
View Options

lib/libsys/waitpid.c

Loading...
View Options

lib/libsys/write.c

Loading...
View Options

lib/libsys/writev.c

Loading...