Page MenuHomeFreeBSD
Differential D40554

bhyve: Move kernemu to amd64/
ClosedPublic
Actions

Authored by markj on Jun 14 2023, 9:52 PM.
Tags
None
Referenced Files
F96498643: D40554.diff
Wed, Sep 25, 6:21 AM
Unknown Object (File)
Sun, Sep 15, 4:32 PM
Unknown Object (File)
Wed, Sep 11, 7:34 PM
Unknown Object (File)
Sun, Sep 8, 11:29 PM
Unknown Object (File)
Fri, Sep 6, 1:44 AM
Unknown Object (File)
Sun, Sep 1, 10:24 AM
Unknown Object (File)
Sun, Sep 1, 7:32 AM
Unknown Object (File)
Aug 21 2024, 2:24 PM
View All 45 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
corvink
andrew
emaste
Group Reviewers
bhyve
Commits
rG013da5d9c415: bhyve: Move kernemu to amd64/
rGa1642451ce25: bhyve: Move kernemu to amd64/
Summary

This code handles instruction emulation for accesses to various
amd64-specific MMIO regions.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jun 14 2023, 9:52 PM
Herald added a reviewer: bhyve. · View Herald TranscriptJun 14 2023, 9:52 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
markj requested review of this revision.Jun 14 2023, 9:52 PM
Harbormaster completed remote builds in B52069: Diff 123256.Jun 14 2023, 9:52 PM
markj added a parent revision: D40553: bhyve: Sort SRCS.Jun 14 2023, 9:52 PM
markj added a child revision: D40555: bhyve: Remove special no-op handling for I/O port 0x488.
jhb accepted this revision.Jun 14 2023, 11:31 PM
jhb added inline comments.
usr.sbin/bhyve/bhyverun.c
93

This should be in the e820 commit?

This revision is now accepted and ready to land.Jun 14 2023, 11:31 PM
corvink accepted this revision.Jun 15 2023, 6:03 AM
markj updated this revision to Diff 123308.Jun 15 2023, 10:13 PM
markj marked an inline comment as done.

Rebase, handle review feedback.

This revision now requires review to proceed.Jun 15 2023, 10:13 PM
Harbormaster completed remote builds in B52096: Diff 123308.Jun 15 2023, 10:13 PM
corvink accepted this revision.Jun 16 2023, 5:33 AM

You have to add kernemu_dev.c to amd64/Makefile.inc. Besides that, LGTM.

This revision is now accepted and ready to land.Jun 16 2023, 5:33 AM
markj mentioned this in D40501: bhyve: Start moving machine-dependent code into subdirectories.Jun 16 2023, 2:03 PM
markj updated this revision to Diff 123338.Jun 16 2023, 2:03 PM

Update makefiles as well.

This revision now requires review to proceed.Jun 16 2023, 2:03 PM
Harbormaster completed remote builds in B52104: Diff 123338.Jun 16 2023, 2:04 PM
jhb accepted this revision.Jun 16 2023, 11:30 PM
This revision is now accepted and ready to land.Jun 16 2023, 11:30 PM
corvink accepted this revision.Jun 19 2023, 5:33 AM
emaste accepted this revision.Jun 21 2023, 4:27 PM
Closed by commit rGa1642451ce25: bhyve: Move kernemu to amd64/ (authored by markj). · Explain WhyOct 4 2023, 4:54 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGa1642451ce25: bhyve: Move kernemu to amd64/.
markj added a commit: rG013da5d9c415: bhyve: Move kernemu to amd64/.Oct 11 2023, 1:25 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
3 lines
amd64/
4 lines
amd64/
6 lines

Diff 128237

View Options

usr.sbin/bhyve/Makefile

Loading...
View Options

usr.sbin/bhyve/amd64/Makefile.inc

Loading...
View Options

usr.sbin/bhyve/amd64/kernemu_dev.h

Loading...
View Options

usr.sbin/bhyve/amd64/kernemu_dev.c

Loading...
View Options

usr.sbin/bhyve/bhyverun.c

Loading...
View Options

usr.sbin/bhyve/kernemu_dev.h

Loading...
View Options

usr.sbin/bhyve/kernemu_dev.c

Loading...