Page MenuHomeFreeBSD

bhyve: Add PL011 UART emulation
ClosedPublic

Authored by markj on Jul 12 2023, 1:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 12:59 PM
Unknown Object (File)
Mon, Oct 21, 5:11 PM
Unknown Object (File)
Oct 3 2024, 9:03 PM
Unknown Object (File)
Oct 3 2024, 8:49 AM
Unknown Object (File)
Oct 3 2024, 6:23 AM
Unknown Object (File)
Sep 28 2024, 1:21 PM
Unknown Object (File)
Sep 28 2024, 5:18 AM
Unknown Object (File)
Sep 27 2024, 5:59 PM

Details

Summary

This is to be used instead of the existing ns16550 emulation, with which
it shares backend code from uart_backend.c.

Obtained from https://github.com/zxombie/freebsd/tree/bhyvearm64

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 12 2023, 1:52 PM
jhb added inline comments.
usr.sbin/bhyve/uart_emul.h
37–38

Maybe fix this part in the original commit adding uart_backend.c?

This revision is now accepted and ready to land.Jul 12 2023, 6:50 PM
corvink added inline comments.
usr.sbin/bhyve/aarch64/uart_pl011.c
1 ↗(On Diff #124559)

Is the ns16550 and pl011 uart really MD? amd64 may make use of ns16550 while arm64 makes use of pl011 by default. However, if both emulations can be used on both architectures, we shouldn't move the code to amd64/ or aarch64/.

markj added inline comments.
usr.sbin/bhyve/aarch64/uart_pl011.c
1 ↗(On Diff #124559)

Yes, I probably should keep them in the base directory. Originally I added uart_pl011.c to aarch64 because it was somewhat coupled to the FDT builder.

This revision was automatically updated to reflect the committed changes.