Page MenuHomeFreeBSD

bhyve: Make gdb support optional
ClosedPublic

Authored by markj on Jul 12 2023, 1:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 25 2025, 5:15 PM
Unknown Object (File)
Feb 17 2025, 11:02 AM
Unknown Object (File)
Feb 17 2025, 10:46 AM
Unknown Object (File)
Feb 14 2025, 1:56 AM
Unknown Object (File)
Feb 9 2025, 6:07 PM
Unknown Object (File)
Jan 24 2025, 8:34 PM
Unknown Object (File)
Jan 24 2025, 1:36 PM
Unknown Object (File)
Jan 22 2025, 12:42 AM
Subscribers

Details

Summary

Add a BHYVE_GDB_SUPPORT make variable that can be set by per-arch
makefiles. When set, BHYVE_GDB is defined and can be used as a
preprocessor predicate. Use it to guard gdb stub calls in MI code.

The arm64 bhyve port currently does not have a functional gdb stub, but
that's not critical to landing the port, so this mechanism slightly
reduces the friction of adding support for a new platform.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 12 2023, 1:51 PM
jhb added inline comments.
usr.sbin/bhyve/bhyverun.c
149

Do you want to make '-G' here conditional on BHYVE_GDB? (Not sure how messy the usage() function ends up at the end of all this)

This revision is now accepted and ready to land.Jul 12 2023, 6:33 PM
This revision was automatically updated to reflect the committed changes.