Differential D40991

bhyve: Move the vm_inject_fault() implementation to vmexit.c
ClosedPublic
Actions

Authored by markj on Jul 12 2023, 1:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 8:13 PM

	Unknown Object (File)
	Mon, Oct 21, 5:34 PM

	Unknown Object (File)
	Mon, Oct 21, 5:10 PM

	Unknown Object (File)
	Sun, Oct 20, 9:34 AM

	Unknown Object (File)
	Sun, Oct 13, 12:48 AM

	Unknown Object (File)
	Oct 1 2024, 12:01 AM

	Unknown Object (File)
	Sep 28 2024, 12:37 PM

	Unknown Object (File)
	Sep 28 2024, 12:28 AM

View All 41 Files

Subscribers

Details

Reviewers

jhb
corvink
andrew

Group Reviewers

Commits

rG8f485cac6302: bhyve: Move the vm_inject_fault() implementation to vmexit.c
rG7228ad8da93b: bhyve: Move the vm_inject_fault() implementation to vmexit.c

Summary

This function isn't generic and has a different signature on arm64. No
functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 12 2023, 1:51 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 12 2023, 1:51 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jul 12 2023, 1:51 PM

Harbormaster completed remote builds in B52584: Diff 124553.Jul 12 2023, 1:51 PM

markj added a parent revision: D40990: bhyve: Build the HPET ACPI table on amd64 only.Jul 12 2023, 1:51 PM

markj added a child revision: D40992: bhyve: Use vm_get_highmem_base() instead of hard-coding the value.

jhb accepted this revision.Jul 12 2023, 6:43 PM

This revision is now accepted and ready to land.Jul 12 2023, 6:43 PM

corvink accepted this revision.Jul 13 2023, 5:56 AM

corvink added inline comments.

usr.sbin/bhyve/amd64/vmexit.c
60	I'm not familiar with arm64 but this function strongly looks like a generic one. Is it really so different, that it's not worth creating a generic function?

jhb added inline comments.Jul 13 2023, 4:28 PM

usr.sbin/bhyve/amd64/vmexit.c
60	The difference is that the arguments are all MD. On ARM64 rather than using an IDT vector and error code pushed on the stack you have ESR and FAR register values. The notion of injecting a fault is generic, but the specific status codes and registers involved are all MD.

Closed by commit rG7228ad8da93b: bhyve: Move the vm_inject_fault() implementation to vmexit.c (authored by markj). · Explain WhyOct 4 2023, 5:00 PM

This revision was automatically updated to reflect the committed changes.

markj marked 2 inline comments as done.

markj added a commit: rG7228ad8da93b: bhyve: Move the vm_inject_fault() implementation to vmexit.c.

markj added a commit: rG8f485cac6302: bhyve: Move the vm_inject_fault() implementation to vmexit.c.Oct 11 2023, 1:26 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

amd64/

13 lines

13 lines

Diff 128255

usr.sbin/bhyve/amd64/vmexit.c

Loading...

usr.sbin/bhyve/bhyverun.c

Loading...