mptable and the e820 are both rather amd64-specific and can be moved
easily.
In the case of e820, move the registration with qemu_fwcfg into e820.c,
as it simplifies bhyverun.c a bit and I can't see any downsides.
No functional change intended.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 52067 Build 48958: arc lint + arc unit
Event Timeline
| usr.sbin/bhyve/bhyverun.c | ||
|---|---|---|
| 97 | Should the header move into amd64/? | |
| usr.sbin/bhyve/bhyverun.c | ||
|---|---|---|
| 97 | Hmm, looks like you fixed this in a later commit, so maybe that fix needs to move to this commit instead? | |
| usr.sbin/bhyve/bhyverun.c | ||
|---|---|---|
| 1377 | This might be slightly confusing if someone passes -Y to non-x86 bhyve and gets a usage message. We could arguably just ignore -Y on non-x86 since it is a disable flag. In any case this likely needs a more comprehensive rework and as a step to making progress on arm64 bhyve I think it's acceptable for now. | |
| usr.sbin/bhyve/bhyverun.c | ||
|---|---|---|
| 1377 | Yes, this certainly needs more work. Right now I'm just trying to minimize the userspace diff to the arm64 port so that rebasing/landing it will be marginally easier. This particular problem will be handled by splitting some of the getopt handling into a separate file. (I have a number of more changes along these lines, I'm going to hold off on committing them until I'm mostly done.) | |