Page MenuHomeFreeBSD
Differential D45065

param.h: Add PAGE_SIZE_MAX and PAGE_SHIFT_MAX
Needs ReviewPublic
Actions

Authored by andrew on Thu, May 2, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:11 PM
Unknown Object (File)
Fri, May 3, 5:39 AM
Unknown Object (File)
Fri, May 3, 5:39 AM
Unknown Object (File)
Thu, May 2, 11:28 PM
Subscribers
emaste
gallatin
imp
jhibbits
riscv

Details

Reviewers
manu
Summary

These are intended to hold the largest page size the architecture
supports.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57548
Build 54436: arc lint + arc unit

Event Timeline

andrew created this revision.Thu, May 2, 4:38 PM
Herald added a reviewer: manu. · View Herald TranscriptThu, May 2, 4:38 PM
Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript
andrew requested review of this revision.Thu, May 2, 4:38 PM
Harbormaster completed remote builds in B57548: Diff 138026.Thu, May 2, 4:38 PM
andrew added a child revision: D45066: libsys: Fall back to the worst case page size.Thu, May 2, 4:38 PM
andrew mentioned this in D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.Thu, May 2, 4:39 PM
gallatin added a subscriber: gallatin.Thu, May 2, 6:11 PM
gallatin added inline comments.
sys/arm64/include/param.h
101

I thought 64K was mostly theoretical. Eg, we cannot actually boot a 64k kernel, while 16k works just fine with a few minor fixes.

andrew added inline comments.Fri, May 3, 9:17 AM
sys/arm64/include/param.h
101

This creates an ABI that userspace will use in jemalloc. If we add a 64k kernel later then we would have to bump this and wouldn't be able to run old binaries.

emaste added inline comments.Fri, May 3, 2:28 PM
sys/arm64/include/param.h
101

What is the cost of having this be 64K vs 16K (if we never implemented a 64K kernel)?

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
2 lines
arm/
include/
2 lines
arm64/
include/
3 lines
i386/
include/
2 lines
powerpc/
include/
2 lines
riscv/
include/
2 lines

Diff 138026

View Options

sys/amd64/include/param.h

Loading...
View Options

sys/arm/include/param.h

Loading...
View Options

sys/arm64/include/param.h

Loading...
View Options

sys/i386/include/param.h

Loading...
View Options

sys/powerpc/include/param.h

Loading...
View Options

sys/riscv/include/param.h

Loading...