umass: Be more consistent about how we fail bad commands
Needs ReviewPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Tags

None

Referenced Files

	F115929245: D49473.diff
	Wed, Apr 30, 1:13 PM

	Unknown Object (File)
	Sat, Apr 19, 6:09 AM

	Unknown Object (File)
	Sat, Apr 5, 5:50 AM

	Unknown Object (File)
	Fri, Apr 4, 11:25 AM

	Unknown Object (File)
	Wed, Apr 2, 6:35 AM

	Unknown Object (File)
	Mar 28 2025, 5:07 PM

	Unknown Object (File)
	Mar 28 2025, 3:09 PM

	Unknown Object (File)
	Mar 28 2025, 10:26 AM

View All 15 Files

Subscribers

None

Details

Reviewers

markj
ken
mav
chs

Summary

Elsewhere, if we fail a command, we use SCSI code ILLEGAL REQUEST/24/00,
but here we were using the CAM code for illegal request.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63080
Build 59964: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63080: Diff 152572.Mar 23 2025, 9:50 PM

imp added a parent revision: D49472: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform.Mar 23 2025, 9:50 PM

imp added a child revision: D49474: umass: Fix a direct call to sc_transform.

imp added reviewers: markj, ken, mav.Mar 24 2025, 1:02 AM

imp added a reviewer: chs.Wed, Apr 2, 8:06 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

5 lines

Diff 152572

View Options

sys/dev/usb/storage/umass.c

umass: Be more consistent about how we fail bad commandsNeeds ReviewPublicActions