umass: Fail SYNCHRONIZE_CACHE for UFI
Needs ReviewPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Tags

None

Referenced Files

	F115929649: D49468.diff
	Wed, Apr 30, 1:17 PM

	Unknown Object (File)
	Sat, Apr 5, 5:45 AM

	Unknown Object (File)
	Tue, Apr 1, 12:47 AM

	Unknown Object (File)
	Mar 31 2025, 2:07 PM

	Unknown Object (File)
	Mar 31 2025, 2:07 PM

	Unknown Object (File)
	Mar 31 2025, 2:07 PM

	Unknown Object (File)
	Mar 31 2025, 2:07 PM

	Unknown Object (File)
	Mar 31 2025, 2:07 PM

View All 14 Files

Subscribers

None

Details

Reviewers

mav
markj
ken
chs

Summary

Just go ahead and fail SYNCHRONIZE_CACHE commands for UFI. This standard
doesn't have a cache to flush, and the upper layers (aka da) will notice sync
cache failed and won't send it again.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63075
Build 59959: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

imp added a parent revision: D49467: umass: Document the ideal that it's better to fail bad commands.

Harbormaster completed remote builds in B63075: Diff 152567.Mar 23 2025, 9:50 PM

imp added a child revision: D49469: umass: Simplify umass_std_transform to eliminate fake success.Mar 23 2025, 9:50 PM

imp added reviewers: mav, markj, ken.Mar 24 2025, 1:05 AM

imp added a reviewer: chs.Wed, Apr 2, 8:04 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

7 lines

Diff 152567

View Options

sys/dev/usb/storage/umass.c

umass: Fail SYNCHRONIZE_CACHE for UFINeeds ReviewPublicActions