Page MenuHomeFreeBSD

net80211: add VHT MCS in AMRR rate control
ClosedPublic

Authored by adrian on Jan 23 2025, 2:43 AM.
Referenced Files
Unknown Object (File)
Thu, Mar 27, 9:56 PM
Unknown Object (File)
Wed, Mar 26, 10:57 AM
Unknown Object (File)
Mon, Mar 24, 6:04 PM
Unknown Object (File)
Tue, Mar 18, 4:26 PM
Unknown Object (File)
Tue, Mar 18, 3:15 PM
Unknown Object (File)
Sat, Mar 15, 5:20 PM
Unknown Object (File)
Sat, Mar 15, 10:27 AM
Unknown Object (File)
Wed, Mar 12, 6:09 AM

Details

Summary

This is a simple implementation, similar to HT, to generate
VHT MCS rates for testing.

I've verified it seems to do the right thing through
MCS 0..9 and NSS 1..2. It's not very optimal - same issues as
with 11n - but it at least now fully tests the 11ac TX path in
rtwn and the tx rate refactoring.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61904
Build 58788: arc lint + arc unit

Event Timeline

thj requested changes to this revision.Jan 28 2025, 9:48 AM
thj added a subscriber: thj.
thj added inline comments.
sys/net80211/ieee80211_amrr.c
261
262–264
541
This revision now requires changes to proceed.Jan 28 2025, 9:48 AM
sys/net80211/ieee80211_amrr.c
262–264

OOOOOPPPPPSSSSSS

oops fix typo, thanks tom!

bz requested changes to this revision.Feb 22 2025, 10:41 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211_amrr.c
152

This is done in the caller already now?

283

Kind-of want to amend the comment with: (whether supported or not -- ieee80211_vht_node_check_tx_valid_mcs() will catch the unsupported cases)

360

Can you fold these into two lines not four?

401

Reset counters.

564

No { } needed.

569

What is "it"?

595

return ()

597

This line kind-of wants to move below the HT block as there's no need for it before the if (is_enough(..))

This revision now requires changes to proceed.Feb 22 2025, 10:41 AM

updated, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 7:32 PM
This revision was automatically updated to reflect the committed changes.