User Details
User Details
- User Since
- Jan 7 2016, 3:15 PM (436 w, 3 d)
Wed, May 1
Wed, May 1
Thu, Apr 25
Thu, Apr 25
I have a temp fix for this directly in ice and will work with erj@ to have the driver support the vlan ifconfig flags correctly
Apr 11 2024
Apr 11 2024
thj added a comment to D44736: netmap: Add field for carrying packet meta data.
Thanks both for the comments, I didn't think this would be the correct approach, but it seemed easier to create a review for how I would like this to work.
thj added inline comments to D44736: netmap: Add field for carrying packet meta data.
Apr 10 2024
Apr 10 2024
thj requested review of D44736: netmap: Add field for carrying packet meta data.
Apr 2 2024
Apr 2 2024
Mar 27 2024
Mar 27 2024
thj added a comment to D44302: diff: Integrate libdiff from OpenBSD GoT..
Please fix the man page typo, but otherwise looks good to me
Mar 26 2024
Mar 26 2024
thj committed rG73fdbfb91121: netmap: Address errors on memory free in netmap_generic (authored by thj).
netmap: Address errors on memory free in netmap_generic
Mar 25 2024
Mar 25 2024
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
- access ext_arg1 via the accessor
Mar 21 2024
Mar 21 2024
thj added a comment to D44371: netmap: Address errors on memory free in netmap_generic.
updated
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
- swap order of arguments for destructor
- replace an m_freem with m_free
Mar 20 2024
Mar 20 2024
thj updated the diff for D44041: lldb lua: Add some helper functions to deal with netinet.
- Correct copyright statement
- Move then for if statements onto the same line
thj added a comment to D44371: netmap: Address errors on memory free in netmap_generic.
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
- Add a macro for getting netmap adapter from ext_arg1
Mar 19 2024
Mar 19 2024
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
- - use SET_MBUF_DESTRUCTOR to set ext_arg1
Mar 18 2024
Mar 18 2024
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
- - Don't remove the pool lock until we have removed all mbufs
thj added inline comments to D44371: netmap: Address errors on memory free in netmap_generic.
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
- - if the reference has gone after taking the lock don't free the mbuf
Mar 15 2024
Mar 15 2024
thj requested review of D44371: netmap: Address errors on memory free in netmap_generic.
Feb 26 2024
Feb 26 2024
thj updated the diff for D44041: lldb lua: Add some helper functions to deal with netinet.
Address review comments
thj added inline comments to D44041: lldb lua: Add some helper functions to deal with netinet.
Feb 23 2024
Feb 23 2024
pf: Correct SPDX identifier
thj requested review of D44041: lldb lua: Add some helper functions to deal with netinet.
pf: Add a TCP rdr test on IPv6
Oct 6 2023
Oct 6 2023
thj updated the diff for D42105: Add a TCP rdr test on IPv6.
Use immediate mode for tcpdump
enhance comments
thj requested review of D42105: Add a TCP rdr test on IPv6.
Oct 4 2023
Oct 4 2023
Jun 13 2023
Jun 13 2023
Apr 18 2023
Apr 18 2023
Feb 10 2023
Feb 10 2023
Feb 7 2023
Feb 7 2023
Jan 30 2023
Jan 30 2023
thj added a reviewer for D17884: efifb: add a tunable to select the framebuffer cache attribute: Klara.
thj added a reviewer for D17883: cxgbe netmap: Directly flushes batches of 64 packets in lazy_tx_credit_flush: Klara.
Jan 17 2023
Jan 17 2023
thj committed rGfe701c39e8aa: if_tun: Add basic connectivity test with nc tun support (authored by thj).
if_tun: Add basic connectivity test with nc tun support
netcat: Allow nc to be an if_tun tunnel broker
Jan 16 2023
Jan 16 2023
thj added reviewers for D38066: bridge: Add support for emulated netmap mode: Klara, murat_sunnyvalley.io, franco_opnsense.org.
thj added reviewers for D38065: netmap: Fix queue stalls on generic interfaces: Klara, murat_sunnyvalley.io, franco_opnsense.org.
Jan 13 2023
Jan 13 2023
thj committed rG110ce09c90dc: if_lagg: Allow lagg interfaces to be used with netmap (authored by thj).
if_lagg: Allow lagg interfaces to be used with netmap
Jan 12 2023
Jan 12 2023
thj updated the diff for D37435: Allow netcat to be a tun tunnel broker.
Address Kyles review comments
Dec 8 2022
Dec 8 2022
acpi: Tell SMM we will handle CPPC notifications
Dec 7 2022
Dec 7 2022
thj added inline comments to D37624: ppp: improve MSS clamping.
Dec 2 2022
Dec 2 2022
thj changed the visibility for D37195: Remote stack corruption in ping (Embargoed).
Nov 18 2022
Nov 18 2022
thj requested review of D37437: if_tun: Enable tun devices to be used with netmap.
thj retitled D37435: Allow netcat to be a tun tunnel broker from Allow netcat to be a tun tunnel broker
Add tests with this new functionality to test that tun devices can pass packets. to Allow netcat to be a tun tunnel broker.
thj requested review of D37436: if_lagg: Allow lagg interfaces to be used with NetMap.
thj requested review of D37435: Allow netcat to be a tun tunnel broker.
thj accepted D37433: tftp: cleanup.
Nov 14 2022
Nov 14 2022
thj updated the diff for D37195: Remote stack corruption in ping (Embargoed).
- Address further comments from Mark
Nov 2 2022
Nov 2 2022
thj updated the diff for D37195: Remote stack corruption in ping (Embargoed).
- Remove asan from makefiles
thj updated the diff for D37195: Remote stack corruption in ping (Embargoed).
- Ensure there are enough bytes following the icmp header
Oct 30 2022
Oct 30 2022
thj updated subscribers of D37195: Remote stack corruption in ping (Embargoed).
Oct 28 2022
Oct 28 2022
thj updated subscribers of D37195: Remote stack corruption in ping (Embargoed).
thj requested review of D37195: Remote stack corruption in ping (Embargoed).
Oct 27 2022
Oct 27 2022
Oct 23 2022
Oct 23 2022
thj committed rG15bd2f366d3e: acpi: Create cppc_notify sysctl before it is checked (authored by thj).
acpi: Create cppc_notify sysctl before it is checked
Oct 21 2022
Oct 21 2022
thj requested review of D37081: acpi: Create cppc_notify sysctl before it is checked.
thj requested review of D37079: diff: Fix matching of CRLF when ignoring white space.
Oct 11 2022
Oct 11 2022
acpi: Put CPPC workaround behind i386/amd64 if def
Oct 10 2022
Oct 10 2022
thj updated the diff for D36860: diff: Import new diff algorithms from libdiff.
- move libdiff into contrib
acpi: Tell SMM we will handle CPPC notifications
Oct 7 2022
Oct 7 2022
thj updated the diff for D36699: acpi: Tell SMM we will handle CPPC notifications.
- use a RDTUN sysctl rather than a hint
- Use a global control for cppc notifications
Oct 6 2022
Oct 6 2022
thj updated the diff for D36699: acpi: Tell SMM we will handle CPPC notifications.
- Simplify hint name
Oct 5 2022
Oct 5 2022
thj updated the diff for D36699: acpi: Tell SMM we will handle CPPC notifications.
- Add a hint to disable the workaround
Oct 3 2022
Oct 3 2022
thj updated the test plan for D36860: diff: Import new diff algorithms from libdiff.
thj requested review of D36860: diff: Import new diff algorithms from libdiff.
Sep 25 2022
Sep 25 2022
thj requested review of D36699: acpi: Tell SMM we will handle CPPC notifications.
Sep 2 2022
Sep 2 2022
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Aug 29 2022
Aug 29 2022
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Update to building version
Aug 2 2022
Aug 2 2022
thj committed rGc0e6ccb12ab9: diff3: Use ranges for the old and new diffedits in A scripts (authored by thj).
diff3: Use ranges for the old and new diffedits in A scripts
diff3: Simplify startmark calculation in Ascript
thj committed rG190c4c2499e6: diff3: Use ranges for new and old diffedits in ed scripts (authored by thj).
diff3: Use ranges for new and old diffedits in ed scripts
thj added inline comments to D34343: libc: iconv: push option ignore into citrus_iconv_open().
thj added inline comments to D34344: libc: iconv: add mb_cur_min for encoder traits.
Looks good to me
Aug 1 2022
Aug 1 2022
diff3: Replace literal marker with variable
diff3: Use variables for old and new in A scripts
diff3: Fix indentation
Jul 20 2022
Jul 20 2022
thj committed rGdc2e12abb22a: Unlock inp when handling TCP_MD5SIG socket options (authored by Claudio Jeker <claudio@openbsd.org>).
Unlock inp when handling TCP_MD5SIG socket options
Jul 5 2022
Jul 5 2022
xargs: fix description of strnsubst return value
thj committed rGf058359ba5e0: xargs: terminate if line replacement cannot be constructed (authored by thj).
xargs: terminate if line replacement cannot be constructed
thj updated the diff for D35574: xargs: terminate if line replacement cannot be constructed.
- make strnsubst return a bool indicating if truncation occured
diff3: make the eflag logic easier to follow
thj updated the diff for D35324: Try to make eflag easier to follow.
simplfy the eflag based on suggestions by dim