net80211: change ieee80211_ratectl_rate() to not return a rix

[adrian]

Summary

There are only a few places where the returned rix is used:

• linuxkpi - logging
• bwi/bwn - used for finding a fallback rate to choose, which honestly should be returned by the ratectl API
• iwm - building the rateset to program into firmware

Everyone else uses the dot11rate value in ni->ni_txnode.

This is a precursor for VHT and later rate support; where currently
there aren't rate tables in ieee80211_phy.c for VHT and later
rates.

Although it's likely doable to add tables for VHT, 11ax and MU-OFDMA
(HE) rates are sufficiently larger/different to just not fit in the
current scheme without more refactoring.

[adrian]

rebsae

[adrian]

rebase

[thj]

sys/compat/linuxkpi/common/src/linux_80211.c

6948

This cast isn't needed

[adrian]

sys/compat/linuxkpi/common/src/linux_80211.c

6948

I'm so used to using/building in envs where you get a warning if you don't handle the return value. :-) Lemme go make sure that doesn't happen here on all of our branches and then I'll go remove em all.

[bz]

sys/compat/linuxkpi/common/src/linux_80211.c

6948

remove it!

sys/dev/iwm/if_iwm.c

4582

Please declare within proper scope or pass the result from the function to the next w/o variable. A dot11rate is an uint8_t anyway

sys/net80211/ieee80211_ratectl.h

135

Cast not needed.

[adrian]

rebase, address changes

[adrian]

address comments

[adrian]

updated, please re-review!

[adrian]

update, add TXRATE_HT

[adrian]

update, add TXRATE_HT

[adrian]

gaivn reported iwm being broken and .. well, now i know why.

rix here isn't index into the rate table, it's an index into the rateset/ht_rateset
in the node.

[adrian]

oops, missed a bit

[thj]

I'm happy with the ieee80211 and driver changes, but bz@ should respond for the linuxkpi as he has all the experience there.

[bz]

Seems fine