Paths

Table of Contentst

Differential D48521

depend-cleanup: Add examples for the common cases
ClosedPublic
Actions

Authored by emaste on Jan 20 2025, 2:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 12, 2:40 PM

	Unknown Object (File)
	Mon, Mar 3, 5:48 PM

	Unknown Object (File)
	Mon, Mar 3, 4:48 PM

	Unknown Object (File)
	Fri, Feb 28, 11:42 AM

	Unknown Object (File)
	Fri, Feb 21, 11:20 AM

	Unknown Object (File)
	Feb 17 2025, 12:37 AM

	Unknown Object (File)
	Feb 13 2025, 2:23 AM

	Unknown Object (File)
	Feb 12 2025, 1:28 AM

View All 25 Files

Subscribers

None

Details

Reviewers

fuz
andrew
jrtc27
imp

Commits

rG87eaa30e9b39: depend-cleanup: Add examples for common cases

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Prompted by D48519

tools/build/depend-cleanup.sh
99	oops, will undo of course

emaste added inline comments.Jan 20 2025, 2:16 PM

tools/build/depend-cleanup.sh
41–55	Generated to committed is really just a special case of moving from one directory to another, so perhaps mention moving first, then the additional step for generated files of removing the stale file.

Reorder two examples

fuz added inline comments.Jan 20 2025, 2:49 PM

tools/build/depend-cleanup.sh
88	This could be clearer. It is not obvious how that regex fixes the detection of the move. Maybe we could add a variant of `clean_dep` that automatically builds the correct regex from the full path of the old source file.

andrew added inline comments.Jan 20 2025, 3:01 PM

tools/build/depend-cleanup.sh
88	It is enough of the old location, with the `/`'s replaced with `.`. We could escape them if it makes things clearer. It just needs to be a regular expression that matches the old location, doesn't match the new location, and doesn't match any dependency shared between them.

Add clarification from @andrew

emaste added a reviewer: imp.Tue, Feb 25, 1:34 PM

andrew accepted this revision.Wed, Mar 12, 2:29 PM

This revision is now accepted and ready to land.Wed, Mar 12, 2:29 PM

Closed by commit rG87eaa30e9b39: depend-cleanup: Add examples for common cases (authored by emaste). · Explain WhyWed, Mar 12, 2:33 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG87eaa30e9b39: depend-cleanup: Add examples for common cases.

Revision Contents
Changeset List

Path

Size

tools/

build/

depend-cleanup.sh

48 lines

Diff 151480

tools/build/depend-cleanup.sh

Loading...