Page MenuHomeFreeBSD
Differential D48521

depend-cleanup: Add examples for the common cases
Needs ReviewPublic
Actions

Authored by emaste on Mon, Jan 20, 2:13 PM.

Details

Reviewers
fuz
andrew
jrtc27

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mon, Jan 20, 2:13 PM
emaste created this revision.

Prompted by D48519

tools/build/depend-cleanup.sh
89

oops, will undo of course

emaste added inline comments.Mon, Jan 20, 2:16 PM
tools/build/depend-cleanup.sh
41–55

Generated to committed is really just a special case of moving from one directory to another, so perhaps mention moving first, then the additional step for generated files of removing the stale file.

emaste updated this revision to Diff 149540.Mon, Jan 20, 2:21 PM

Reorder two examples

fuz added inline comments.Mon, Jan 20, 2:49 PM
tools/build/depend-cleanup.sh
78

This could be clearer. It is not obvious how that regex fixes the detection of the move.

Maybe we could add a variant of clean_dep that automatically builds the correct regex from the full path of the old source file.

andrew added inline comments.Mon, Jan 20, 3:01 PM
tools/build/depend-cleanup.sh
78

It is enough of the old location, with the /'s replaced with .. We could escape them if it makes things clearer.

It just needs to be a regular expression that matches the old location, doesn't match the new location, and doesn't match any dependency shared between them.

Revision Contents
Changeset List

PathSize
tools/
build/
40 lines

Diff 149539

View Options

tools/build/depend-cleanup.sh

Loading...