Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| tools/build/depend-cleanup.sh | ||
|---|---|---|
| 41–55 | Generated to committed is really just a special case of moving from one directory to another, so perhaps mention moving first, then the additional step for generated files of removing the stale file. | |
| tools/build/depend-cleanup.sh | ||
|---|---|---|
| 46 | This could be clearer. It is not obvious how that regex fixes the detection of the move. Maybe we could add a variant of clean_dep that automatically builds the correct regex from the full path of the old source file. | |
| tools/build/depend-cleanup.sh | ||
|---|---|---|
| 46 | It is enough of the old location, with the /'s replaced with .. We could escape them if it makes things clearer. It just needs to be a regular expression that matches the old location, doesn't match the new location, and doesn't match any dependency shared between them. | |