Page MenuHomeFreeBSD
Differential D48035

sound: Remove macro magic from pcm/feeder_matrix.c
ClosedPublic
Actions

Authored by christos on Dec 11 2024, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 11:14 PM
Unknown Object (File)
Wed, Feb 26, 11:06 PM
Unknown Object (File)
Feb 14 2025, 5:02 PM
Unknown Object (File)
Feb 13 2025, 5:57 AM
Unknown Object (File)
Feb 10 2025, 11:33 PM
Unknown Object (File)
Feb 8 2025, 4:00 PM
Unknown Object (File)
Feb 8 2025, 3:15 AM
Unknown Object (File)
Feb 8 2025, 2:16 AM
View All 30 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGa25f84cf0910: sound: Remove macro magic from pcm/feeder_matrix.c
rGac24c9da8bb7: sound: Remove macro magic from pcm/feeder_matrix.c
Summary

Turn the FEEDMATRIX_DECLARE macro into a single inline function
(feed_matrix_apply()). There is no reason to have this as a macro, it
only complicated the code. An advantage of this patch is that, because
we no longer call the functions created by the macro through function
pointers (apply field of feed_matrix_info), we can call
feed_matrix_apply() directly in feed_matrix_feed().

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Dec 11 2024, 4:49 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 11 2024, 4:49 PM
christos requested review of this revision.Dec 11 2024, 4:49 PM
Harbormaster completed remote builds in B61091: Diff 147823.Dec 11 2024, 4:49 PM
christos added a parent revision: D48034: sound: Cache bps in pcm/feeder_eq.c.Dec 11 2024, 4:49 PM
christos added a child revision: D48036: sound: Remove feed_matrix_apply_generic().
dev_submerge.ch added a comment.Dec 13 2024, 3:01 PM

Same as D48032, you may want to call your function with literal format parameters, for performance reasons.

christos mentioned this in D48036: sound: Remove feed_matrix_apply_generic().Dec 15 2024, 10:51 PM
christos updated this revision to Diff 148255.Dec 19 2024, 6:12 PM

Address Florian's comment.

Harbormaster completed remote builds in B61268: Diff 148255.Dec 19 2024, 6:12 PM
christos added a comment.Dec 29 2024, 8:27 PM

Bump.

markj added inline comments.Dec 29 2024, 8:34 PM
sys/dev/sound/pcm/feeder_matrix.c
435

Why can't this entire switch statement just be feed_matrix_apply(info, src, dst, j, info->fmt);?

christos added inline comments.Dec 29 2024, 8:37 PM
sys/dev/sound/pcm/feeder_matrix.c
435

There is related discussion in D48032

christos updated this revision to Diff 148915.Jan 7 2025, 8:54 PM

Mark fmt argument as const.

Harbormaster completed remote builds in B61568: Diff 148915.Jan 7 2025, 8:54 PM
christos added a parent revision: D48421: sound: Turn clamp macros into a function.Jan 10 2025, 6:40 PM
christos updated this revision to Diff 149084.Jan 10 2025, 6:42 PM

Rebase on top of D48421.

Harbormaster completed remote builds in B61654: Diff 149084.Jan 10 2025, 6:42 PM
christos removed a parent revision: D48034: sound: Cache bps in pcm/feeder_eq.c.Jan 10 2025, 6:46 PM
christos updated this revision to Diff 149173.Jan 13 2025, 1:23 PM

Clamp accum, not v, as in the original code.

Harbormaster completed remote builds in B61692: Diff 149173.Jan 13 2025, 1:23 PM
christos added a comment.Jan 30 2025, 3:37 PM

Bump.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Mar 10, 8:22 PM
Closed by commit rGac24c9da8bb7: sound: Remove macro magic from pcm/feeder_matrix.c (authored by christos). · Explain Why
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGac24c9da8bb7: sound: Remove macro magic from pcm/feeder_matrix.c.
christos added a commit: rGa25f84cf0910: sound: Remove macro magic from pcm/feeder_matrix.c.Mon, Mar 17, 6:38 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
185 lines

Diff 152112

View Options

sys/dev/sound/pcm/feeder_matrix.c

Loading...