sound: Remove feed_matrix_apply_generic()

[christos]

Summary

It does what feed_matrix_apply() already does, so it is redundant.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

[dev_submerge.ch]

There's more #ifdef FEEDMATRIX_GENERIC code which references this, no?

[christos]

In D48036#1095737, @dev_submerge.ch wrote:

There's more #ifdef FEEDMATRIX_GENERIC code which references this, no?

No. D48035 removes the other code which assigns feed_matrix_apply_generic() as the callback.

[dev_submerge.ch]

In D48036#1096250, @christos wrote:

In D48036#1095737, @dev_submerge.ch wrote:

There's more #ifdef FEEDMATRIX_GENERIC code which references this, no?

No. D48035 removes the other code which assigns feed_matrix_apply_generic() as the callback.

Oh, missed that. I don't have all these changes in my tree since they don't apply cleanly from D47638 on.

[christos]

In D48036#1096286, @dev_submerge.ch wrote:

In D48036#1096250, @christos wrote:

In D48036#1095737, @dev_submerge.ch wrote:

There's more #ifdef FEEDMATRIX_GENERIC code which references this, no?

No. D48035 removes the other code which assigns feed_matrix_apply_generic() as the callback.

Oh, missed that. I don't have all these changes in my tree since they don't apply cleanly from D47638 on.

Yeap... I shuffled some patches around to re-organize them in a more intuitive way, so it's quite a mess right now to apply the patches cleanly. The current sequence of patches in my local tree is (from oldest to newest):

sound: Clean up pcm/ includes
sound: Bail out early if a format is not supported
sound: Refactor the format conversion framework
sound: Remove macro magic from pcm/feeder_eq.c
sound: Remove FEEDEQ_CLAMP()
sound: Cache bps in pcm/feeder_eq.c
sound: Remove macro magic from pcm/feeder_matrix.c
sound: Remove feed_matrix_apply_generic()
sound: Implement AFMT_FLOAT support
beep(1): Use AFMT_FLOAT
sound: Allocate vchans on-demand
sound: Simplify vchan_getparentchannel()
sound: Remove SNDBUF_LOCKASSERT()
sound: Improve afmt_tab
sound: Get rid of redundant variables in chn_setspeed() and chn_setformat()
sound: Return if the new speed/format is the same as the current one

[dev_submerge.ch]

In D48036#1096288, @christos wrote:

Yeap... I shuffled some patches around to re-organize them in a more intuitive way, so it's quite a mess right now to apply the patches cleanly. The current sequence of patches in my local tree is (from oldest to newest):

sound: Clean up pcm/ includes
sound: Bail out early if a format is not supported
sound: Refactor the format conversion framework
sound: Remove macro magic from pcm/feeder_eq.c
sound: Remove FEEDEQ_CLAMP()
sound: Cache bps in pcm/feeder_eq.c
sound: Remove macro magic from pcm/feeder_matrix.c
sound: Remove feed_matrix_apply_generic()
sound: Implement AFMT_FLOAT support
beep(1): Use AFMT_FLOAT
sound: Allocate vchans on-demand
sound: Simplify vchan_getparentchannel()
sound: Remove SNDBUF_LOCKASSERT()
sound: Improve afmt_tab
sound: Get rid of redundant variables in chn_setspeed() and chn_setformat()
sound: Return if the new speed/format is the same as the current one

Must be the new git rebase --random-reshuffle feature I heard so much about ;-)
Unfortunately this order only works if you update all the reviews. The patches in reviews come with a certain amount of context (surrounding code), and git arc will refuse to apply if that doesn't match.