beep(1): Use AFMT_FLOAT
Needs ReviewPublic
Actions

Authored by christos on Sat, Nov 16, 6:18 PM.

Tags

None

Referenced Files

	F102859646: D47639.id146596.diff
	Mon, Nov 18, 2:37 AM

	F102855067: D47639.id.diff
	Mon, Nov 18, 1:09 AM

	F102847016: D47639.id.diff
	Sun, Nov 17, 10:43 PM

	F102836664: D47639.diff
	Sun, Nov 17, 7:40 PM

	F102835011: D47639.id.diff
	Sun, Nov 17, 7:06 PM

	F102834903: D47639.id146596.diff
	Sun, Nov 17, 7:04 PM

	Unknown Object (File)
	Sun, Nov 17, 5:14 PM

	Unknown Object (File)
	Sat, Nov 16, 6:19 PM

Subscribers

imp

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

AFMT_FLOAT is supported by sound(4) as of FILLME, so use it here, since
the whole program works with floats already.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60633
Build 57517: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Nov 16, 6:18 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 16, 6:18 PM

christos requested review of this revision.Sat, Nov 16, 6:18 PM

Harbormaster completed remote builds in B60633: Diff 146596.Sat, Nov 16, 6:18 PM

christos added a parent revision: D47638: sound: Implement AFMT_FLOAT support.Sat, Nov 16, 6:19 PM

I'd suggest we not do this, at least not before quantifying the performance impact of float support (see comment in D47638).

Revision Contents
Changeset List

Path

Size

usr.bin/

beep/

beep.c

8 lines

Diff 146596

View Options

beep(1): Use AFMT_FLOATNeeds ReviewPublicActions