Paths

Table of Contentst

Differential D48035

sound: Remove macro magic from pcm/feeder_matrix.c
Needs ReviewPublic
Actions

Authored by christos on Wed, Dec 11, 4:49 PM.

Tags

None

Referenced Files

	F107004452: D48035.diff
	Wed, Jan 8, 8:20 PM

	Unknown Object (File)
	Thu, Dec 26, 2:26 PM

	Unknown Object (File)
	Thu, Dec 26, 10:15 AM

	Unknown Object (File)
	Thu, Dec 26, 8:03 AM

	Unknown Object (File)
	Thu, Dec 26, 6:14 AM

	Unknown Object (File)
	Mon, Dec 23, 6:56 AM

	Unknown Object (File)
	Sun, Dec 22, 4:55 AM

	Unknown Object (File)
	Wed, Dec 18, 5:34 PM

View All 9 Files

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

Turn the FEEDMATRIX_DECLARE macro into a single inline function
(feed_matrix_apply()). There is no reason to have this as a macro, it
only complicated the code. An advantage of this patch is that, because
we no longer call the functions created by the macro through function
pointers (apply field of feed_matrix_info), we can call
feed_matrix_apply() directly in feed_matrix_feed().

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61268
Build 58152: arc lint + arc unit

Event Timeline

christos created this revision.Wed, Dec 11, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Dec 11, 4:49 PM

christos requested review of this revision.Wed, Dec 11, 4:49 PM

Harbormaster completed remote builds in B61091: Diff 147823.Wed, Dec 11, 4:49 PM

christos added a parent revision: D48034: sound: Cache bps in pcm/feeder_eq.c.Wed, Dec 11, 4:49 PM

christos added a child revision: D48036: sound: Remove feed_matrix_apply_generic().

Same as D48032, you may want to call your function with literal format parameters, for performance reasons.

christos mentioned this in D48036: sound: Remove feed_matrix_apply_generic().Sun, Dec 15, 10:51 PM

Address Florian's comment.

Harbormaster completed remote builds in B61268: Diff 148255.Thu, Dec 19, 6:12 PM

Bump.

markj added inline comments.Sun, Dec 29, 8:34 PM

sys/dev/sound/pcm/feeder_matrix.c
443	Why can't this entire switch statement just be `feed_matrix_apply(info, src, dst, j, info->fmt);`?

christos added inline comments.Sun, Dec 29, 8:37 PM

sys/dev/sound/pcm/feeder_matrix.c
443	There is related discussion in D48032

Mark fmt argument as const.

Harbormaster completed remote builds in B61568: Diff 148915.Tue, Jan 7, 8:54 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

feeder_matrix.c

198 lines

Diff 148255

sys/dev/sound/pcm/feeder_matrix.c

Loading...