Page MenuHomeFreeBSD

sys: Add an SMCCC Random Number Generator driver
ClosedPublic

Authored by andrew on Oct 7 2024, 4:54 PM.
Tags
None
Referenced Files
F106028509: D46989.id144423.diff
Tue, Dec 24, 3:37 AM
Unknown Object (File)
Wed, Dec 18, 2:30 AM
Unknown Object (File)
Wed, Dec 4, 6:02 PM
Unknown Object (File)
Mon, Dec 2, 11:16 PM
Unknown Object (File)
Mon, Dec 2, 11:04 PM
Unknown Object (File)
Nov 19 2024, 4:50 PM
Unknown Object (File)
Nov 9 2024, 10:20 PM
Unknown Object (File)
Nov 6 2024, 8:41 PM

Details

Summary

The Arm True Random Number Generator Firmware Interface provides a way
to query the SMCCC firmware for up to 192 bits of entropy. Use it to
provide another source of randomness to the kernel.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59818
Build 56703: arc lint + arc unit

Event Timeline

andrew requested review of this revision.Oct 7 2024, 4:54 PM

Remove an old TODO comment

markm added a subscriber: markm.

Looks OK to me.

This revision is now accepted and ready to land.Oct 7 2024, 5:15 PM
cem added inline comments.
sys/dev/psci/smccc_trng.c
113

If this source supports 192 bits per request, why truncate to 64?

118

Earlier we use arm_smccc_invoke. What’s the difference?

  • Check for SMCCC 1.1
  • Remove an unused variable
  • Use arm_smccc_invoke
This revision now requires review to proceed.Oct 9 2024, 9:22 AM
sys/dev/psci/smccc_trng.c
113

It's simpler to do so and we only ever ask for 64 bits in random_sources_feed

This revision is now accepted and ready to land.Oct 9 2024, 5:26 PM