Page MenuHomeFreeBSD

sys: Add an SMCCC Random Number Generator driver
ClosedPublic

Authored by andrew on Mon, Oct 7, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 10:16 AM
Unknown Object (File)
Thu, Oct 31, 5:38 PM
Unknown Object (File)
Tue, Oct 15, 7:34 PM
Unknown Object (File)
Sat, Oct 12, 4:05 PM
Unknown Object (File)
Sat, Oct 12, 12:20 AM
Unknown Object (File)
Sat, Oct 12, 12:18 AM
Unknown Object (File)
Fri, Oct 11, 8:25 PM
Unknown Object (File)
Wed, Oct 9, 2:52 AM

Details

Summary

The Arm True Random Number Generator Firmware Interface provides a way
to query the SMCCC firmware for up to 192 bits of entropy. Use it to
provide another source of randomness to the kernel.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Mon, Oct 7, 4:54 PM

Remove an old TODO comment

markm added a subscriber: markm.

Looks OK to me.

This revision is now accepted and ready to land.Mon, Oct 7, 5:15 PM
cem added inline comments.
sys/dev/psci/smccc_trng.c
114

If this source supports 192 bits per request, why truncate to 64?

119

Earlier we use arm_smccc_invoke. What’s the difference?

  • Check for SMCCC 1.1
  • Remove an unused variable
  • Use arm_smccc_invoke
This revision now requires review to proceed.Wed, Oct 9, 9:22 AM
sys/dev/psci/smccc_trng.c
114

It's simpler to do so and we only ever ask for 64 bits in random_sources_feed

This revision is now accepted and ready to land.Wed, Oct 9, 5:26 PM