Page MenuHomeFreeBSD
Differential D46584

pfctl: improve bitmask printing
ClosedPublic
Actions

Authored by kp on Sat, Sep 7, 9:35 AM.
Tags
None
Referenced Files
F95835088: D46584.diff
Sun, Sep 22, 7:35 PM
Unknown Object (File)
Thu, Sep 19, 10:31 PM
Unknown Object (File)
Wed, Sep 18, 9:57 PM
Unknown Object (File)
Tue, Sep 17, 7:41 PM
Unknown Object (File)
Tue, Sep 17, 12:18 AM
Unknown Object (File)
Thu, Sep 12, 8:58 AM
Unknown Object (File)
Tue, Sep 10, 4:57 AM
Unknown Object (File)
Tue, Sep 10, 4:40 AM
View All 16 Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rGe044f67a66c8: pfctl: improve bitmask printing
Summary

In some cases the netmask gets set to a full 128 bit mask even if no
address family is selected; don't print the v6 mask if it's a v4 address.

Obtained from: OpenBSD, mcbride <mcbride@openbsd.org>, f6d7b41f07
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59372
Build 56259: arc lint + arc unit

Event Timeline

kp created this revision.Sat, Sep 7, 9:35 AM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 7, 9:35 AM
kp requested review of this revision.Sat, Sep 7, 9:35 AM
kp added a parent revision: D46583: pf: fix potential memory leaks in pf_create_state().
Harbormaster completed remote builds in B59372: Diff 143080.Sat, Sep 7, 9:35 AM
kp added a child revision: D46585: pf: print rule number in debug output.Sat, Sep 7, 9:35 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Sep 19, 8:21 PM
Closed by commit rGe044f67a66c8: pfctl: improve bitmask printing (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGe044f67a66c8: pfctl: improve bitmask printing.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
2 lines

Diff 143080

View Options

sbin/pfctl/pf_print_state.c

Loading...